Skip to content

adding clrgc variant with regions enabled #89129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mangod9 merged 3 commits into from
Jul 28, 2023
Merged

adding clrgc variant with regions enabled #89129

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44970de
adding clrgc variant with regions enabled
mangod9 Jul 18, 2023
4f2628d
only build regions for 64 bit platforms
mangod9 Jul 18, 2023
ac0163f
rename to clrgcexp for experimental
mangod9 Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/coreclr/gc/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,16 @@ list(APPEND GC_SOURCES ${GC_HEADERS})

convert_to_absolute_path(GC_SOURCES ${GC_SOURCES})

# clrgcr is build with standalone+regions
if (CLR_CMAKE_TARGET_ARCH_ARM64 OR CLR_CMAKE_TARGET_ARCH_AMD64)
Copy link
Copy Markdown
Member Author

@mangod9 mangod9 Jul 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this builds clrgcr.dll (and libclrgcr.so) on 64 bit platforms. We could change naming if required.

Copy link
Copy Markdown
Member

@mrsharm mrsharm Jul 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: for the sake of readability, would it be better to change the name to: clrgc_regions?

Copy link
Copy Markdown
Member Author

@mangod9 mangod9 Jul 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didnt want to name it as regions since longer term it might be for a different feature. Perhaps something like experimental or something. Maybe rename it clrgce for experimental ?

Copy link
Copy Markdown
Member

@Maoni0 Maoni0 Jul 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clrgcexp?

Copy link
Copy Markdown
Member Author

@mangod9 mangod9 Jul 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah that works, will rename.

add_library_clr(clrgcr SHARED ${GC_SOURCES})
add_dependencies(clrgcr eventing_headers)
target_link_libraries(clrgcr PRIVATE ${GC_LINK_LIBRARIES})
target_compile_definitions(clrgcr PRIVATE -DUSE_REGIONS)
install_clr(TARGETS clrgcr DESTINATIONS . COMPONENT runtime)
endif (CLR_CMAKE_TARGET_ARCH_ARM64 OR CLR_CMAKE_TARGET_ARCH_AMD64)

# clrgc is build with standalone+segments
Comment thread
mangod9 marked this conversation as resolved.
add_library_clr(clrgc SHARED ${GC_SOURCES})
add_dependencies(clrgc eventing_headers)
target_link_libraries(clrgc PRIVATE ${GC_LINK_LIBRARIES})
Expand Down