Stop skipping tests in installer pipeline on linux_x64#89953
Merged
elinor-fung merged 3 commits intodotnet:mainfrom Aug 18, 2023
Merged
Stop skipping tests in installer pipeline on linux_x64#89953elinor-fung merged 3 commits intodotnet:mainfrom
elinor-fung merged 3 commits intodotnet:mainfrom
Conversation
ghost
assigned
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue Detailsnull
|
elinor-fung
force-pushed
the
installerPipelineTests
branch
2 times, most recently
from
02f7bae to
d27fc38
Compare
elinor-fung
force-pushed
the
installerPipelineTests
branch
2 times, most recently
from
de05973 to
4fced16
Compare
elinor-fung
force-pushed
the
installerPipelineTests
branch
from
4fced16 to
5649154
Compare
vitek-karas
approved these changes
Aug 18, 2023
Member
vitek-karas
left a comment
vitek-karas
left a comment
There was a problem hiding this comment.
The test changes look good to me. I can't really comment on the YML changes, don't know enough about that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crossBuildparameter (before that, it was never set). Since these tests aren't on Helix yet, they are skipped for cross build - unfortunately, this means we have no tests running on linux. For linux_x64, they still work in this configuration, so this change enables tests in that configuration so that we have some linux coverage.skipTestsparameter, which stopped being set after some infrastructure refactoring.installer linux_x64 leg from this PR build: https://dev.azure.com/dnceng-public/public/_build/results?buildId=363131&view=logs&jobId=128f4634-3e62-52f1-6764-cb4c2b8330d4&j=c5f2201a-1517-53df-cad8-ae304147cc38&t=a15e3034-cc18-5a91-b9dd-0aaebf757d0c