Skip to content

[browser][AOT] Space in path to published project on unix #94306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilonatommy merged 4 commits into from
Dec 5, 2023
Merged

[browser][AOT] Space in path to published project on unix #94306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ff14091
Approach with quotations.
ilonatommy Nov 1, 2023
0258afe
V8Path might contain spaces.
ilonatommy Nov 2, 2023
9de5c86
Merge branch 'main' into space-in-path-unix
ilonatommy Dec 5, 2023
29f5648
Revert unnecessary change
ilonatommy Dec 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/mono/wasm/Wasm.Build.Tests/Common/BuildEnvironment.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,7 @@ public class BuildEnvironment
public static readonly string RelativeTestAssetsPath = @"..\testassets\";
public static readonly string TestAssetsPath = Path.Combine(AppContext.BaseDirectory, "testassets");
public static readonly string TestDataPath = Path.Combine(AppContext.BaseDirectory, "data");
// ActiveIssue for Linux/OSx: https://github.com/dotnet/runtime/issues/92335
public static readonly string TmpPath = RuntimeInformation.IsOSPlatform(OSPlatform.Windows) ?
Path.Combine(AppContext.BaseDirectory, "wbt artifacts") :
Path.Combine(AppContext.BaseDirectory, "wbt");
public static readonly string TmpPath = Path.Combine(AppContext.BaseDirectory, "wbt artifacts");

public static readonly string DefaultRuntimeIdentifier =
#if TARGET_WASI
Expand Down
2 changes: 1 addition & 1 deletion src/mono/wasm/build/WasmApp.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,7 @@
<FileWrites Include="$(WasmRunV8ScriptPath)" />
</ItemGroup>

<Exec Condition="'$(OS)' != 'Windows_NT'" Command="chmod a+x $(WasmRunV8ScriptPath)" />
<Exec Condition="'$(OS)' != 'Windows_NT'" Command="chmod a+x &quot;$(WasmRunV8ScriptPath)&quot;" />
</Target>

<Target Name="_WasmResolveReferences" Condition="'$(WasmResolveAssembliesBeforeBuild)' == 'true'">
Expand Down