Skip to content

[perf] Use HybridGlobalization as default and only option for Apple mobile platforms #96918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kotlarmilos merged 10 commits into from
Jan 15, 2024
Merged

[perf] Use HybridGlobalization as default and only option for Apple mobile platforms #96918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
67bed31
[perf] Use HybridGlobalization as default and only option for Apple m…
kotlarmilos Jan 12, 2024
c35765f
Disable jobs
kotlarmilos Jan 12, 2024
15f1750
Remove empty block in perf-non-wasm-jobs.yml
kotlarmilos Jan 12, 2024
ea813d0
Disable jobs
kotlarmilos Jan 12, 2024
e54439d
Disable jobs
kotlarmilos Jan 12, 2024
67a2e3c
Update eng/pipelines/coreclr/perf-non-wasm-jobs.yml
kotlarmilos Jan 12, 2024
da2d53a
Merge branch 'bugfix/ios-default-hybrid-globalization' of github.com:…
kotlarmilos Jan 12, 2024
6cc62fd
Remove hybrid globalization parameter
kotlarmilos Jan 12, 2024
cc02ee9
Enable perf jobs
kotlarmilos Jan 12, 2024
ce6e584
Revert hybridGlobalization parameter changes
kotlarmilos Jan 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions eng/pipelines/coreclr/perf-non-wasm-jobs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,5 @@
jobs:

- ${{ if and(ne(variables['System.TeamProject'], 'public'), in(variables['Build.Reason'], 'Schedule')) }}:

# Build and run iOS Mono and NativeAOT scenarios with HybridGlobalization
- template: /eng/pipelines/coreclr/templates/build-and-run-perf-ios-scenarios.yml
parameters:
hybridGlobalization: True

- ${{ if and(ne(variables['System.TeamProject'], 'public'), notin(variables['Build.Reason'], 'Schedule')) }}:

# build coreclr and libraries
Expand Down Expand Up @@ -77,10 +70,10 @@ jobs:
platforms:
- linux_x64

# Build and run iOS Mono and NativeAOT scenarios without HybridGlobalization
# Build and run iOS Mono and NativeAOT scenarios
- template: /eng/pipelines/coreclr/templates/build-and-run-perf-ios-scenarios.yml
parameters:
hybridGlobalization: False
hybridGlobalization: True

# run android scenarios
- template: /eng/pipelines/common/platform-matrix.yml
Expand Down
2 changes: 1 addition & 1 deletion eng/pipelines/coreclr/templates/build-and-run-perf-ios-scenarios.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
parameters:
hybridGlobalization: False
hybridGlobalization: True
Comment thread
radical marked this conversation as resolved.

jobs:
# build mono iOS scenarios HybridGlobalization
Expand Down