Merged
Conversation
Member
Author
|
/evaluate |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the skill-validator’s file reference depth/traversal checks so that when repo traversal is explicitly allowed, parent-directory (..) references aren’t incorrectly subjected to the “max 1 directory deep” rule—intended for keeping portable skills self-contained.
Changes:
- Updates
SkillProfilerto suppress depth checking for references that include..whenAllowRepoTraversalis enabled. - Updates/extends unit tests to distinguish between deep external refs (allowed with repo traversal) vs deep internal refs (still rejected).
Show a summary per file
| File | Description |
|---|---|
| eng/skill-validator/src/Check/SkillProfiler.cs | Changes traversal/depth validation flow to skip depth checks for .. refs when repo traversal is allowed. |
| eng/skill-validator/tests/Check/SkillProfileTests.cs | Updates and adds tests for the updated repo-traversal behavior. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comments suppressed due to low confidence (1)
eng/skill-validator/tests/Check/SkillProfileTests.cs:339
- The new coverage verifies that
..-based external refs don't trigger depth errors, but it doesn't cover the important edge case where a path contains..yet still resolves inside the skill directory (e.g.references/../refs/utils/foo/readme.md). Add a test that expects the depth error in that scenario (withAllowRepoTraversal = true) so the implementation can't accidentally allow deep internal refs by inserting..segments.
[Fact]
public void AllowRepoTraversalAllowsDeepExternalRefs()
{
var content = "---\nname: test-skill\n---\n# Title\n1. Step\n```bash\necho\n```\nSee [ref](../../../documentation/guides/setup.md)\n" + new string('x', 4000);
var options = new CheckOptions { AllowRepoTraversal = true };
var profile = SkillProfiler.AnalyzeSkill(MakeSkill(content), options);
Assert.DoesNotContain(profile.Errors, e => e.Contains("traversal") || e.Contains("directories deep"));
}
[Fact]
public void AllowRepoTraversalStillChecksDepthForInternalRefs()
{
var content = "---\nname: test-skill\n---\n# Title\n1. Step\n```bash\necho\n```\nSee [ref](refs/utils/foo/readme.md)\n" + new string('x', 4000);
var options = new CheckOptions { AllowRepoTraversal = true };
var profile = SkillProfiler.AnalyzeSkill(MakeSkill(content), options);
Assert.Contains(profile.Errors, e => e.Contains("directories deep"));
}
- Files reviewed: 2/2 changed files
- Comments generated: 1
ViktorHofer
approved these changes
Apr 14, 2026
Member
Author
|
/evaluate |
Contributor
Skill Validation Results
[1] (Plugin) Quality unchanged but weighted score is -7.9% due to: tokens (19082 → 59936), tool calls (0 → 2)
Model: claude-opus-4.6 | Judge: claude-opus-4.6 🔍 Full Results - additional metrics and failure investigation steps ▶ Sessions Visualisation -- interactive replay of all evaluation sessions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup of #524
Motivation
When we want to allow traversal of paths outside of the skill folder (in case of repo specific skills, that are not meant to be shareable) - we should not check for the depth of the path, unless it is in the current skill folder - otherwise the depth check would snap