Skip to content

Activate and fix missing analyzers in System.Drawing.Common#10300

Merged
lonitra merged 5 commits into
dotnet:mainfrom
halgab:sdc-SA1500
Nov 15, 2023
Merged

Activate and fix missing analyzers in System.Drawing.Common#10300
lonitra merged 5 commits into
dotnet:mainfrom
halgab:sdc-SA1500

Conversation

@halgab

@halgab halgab commented Nov 14, 2023

Copy link
Copy Markdown
Contributor

Fix #10285

This is mostly whitespace changes.

Proposed changes

  • Activate and fix SA1500 and SA1508 in System.Drawing.Common
  • Activate and fix SA1507 in System.Drawing.Common
  • Activate and fix SA1513 in System.Drawing.Common
  • Activate and fix SA1408 in System.Drawing.Common
  • Activate SA1129

@ghost ghost assigned halgab Nov 14, 2023
@halgab halgab force-pushed the sdc-SA1500 branch 3 times, most recently from 14e903c to f0e8b30 Compare November 14, 2023 15:38
@ghost ghost added the draft draft PR label Nov 14, 2023
@halgab halgab force-pushed the sdc-SA1500 branch 5 times, most recently from 5bce6f2 to 2d8b30a Compare November 14, 2023 22:46
@halgab halgab changed the title Activate and fix SA1* in System.Drawing.Common Activate and fix missing analyzers in System.Drawing.Common Nov 15, 2023
@halgab halgab marked this pull request as ready for review November 15, 2023 13:57
@halgab halgab requested a review from a team as a code owner November 15, 2023 13:57
@ghost ghost removed the draft draft PR label Nov 15, 2023

@lonitra lonitra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

public void AddMemoryFont(System.IntPtr memory, int length) { throw new System.PlatformNotSupportedException(System.SR.SystemDrawingCommon_PlatformNotSupported); }
protected override void Dispose(bool disposing) { }
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof.. This class must've initially been ugly in terms readability with all the lines that needed to be added 😄

@lonitra lonitra merged commit 6f9a435 into dotnet:main Nov 15, 2023
@ghost ghost added this to the 9.0 Preview1 milestone Nov 15, 2023
@halgab halgab deleted the sdc-SA1500 branch November 15, 2023 18:00
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cleanup code and re-enable analyzers in System.Drawing.Common

2 participants