fix #12916 Cannot use down to expand ToolStripDropDownButton in toolStrip2 after using right/Left to collapse ToolStripDropDownButton in toolStrip1#13034
Merged
Epica3055 merged 1 commit intodotnet:mainfrom Feb 27, 2025
Conversation
… toolStrip2 after using right/Left to collapse ToolStripDropDownButton in toolStrip1
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13034 +/- ##
===================================================
- Coverage 76.13911% 76.09527% -0.04385%
===================================================
Files 3258 3272 +14
Lines 642851 643701 +850
Branches 47307 47438 +131
===================================================
+ Hits 489461 489826 +365
- Misses 149825 150314 +489
+ Partials 3565 3561 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
JeremyKuhne
approved these changes
Feb 26, 2025
LeafShi1
pushed a commit
to LeafShi1/winforms
that referenced
this pull request
Mar 6, 2025
… toolStrip2 after using right/Left to collapse ToolStripDropDownButton in toolStrip1 (dotnet#13034)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12916
Root cause
When we use Tab key to focus on second ToolStrip and then press down key, ProcessCmdKey method get triggered, but the event owner isn't right, it should have been toolStrip2 not toolStrip1.

Proposed changes
Screenshots
Before
After
Test methodology
Microsoft Reviewers: Open in CodeFlow