Skip to content

fix #13861 The custom ForeColor set on PrintPreviewControl is not rendered correctly#13863

Merged
LeafShi1 merged 3 commits intodotnet:mainfrom
Epica3055:Fix_13861
Sep 19, 2025
Merged

fix #13861 The custom ForeColor set on PrintPreviewControl is not rendered correctly#13863
LeafShi1 merged 3 commits intodotnet:mainfrom
Epica3055:Fix_13861

Conversation

@Epica3055
Copy link
Copy Markdown
Member

@Epica3055 Epica3055 commented Sep 12, 2025

Fixes #13861

Proposed changes

  • pr #12368 is to fix the High Contrast issue but omitted the case that a custom color is set.
  • if ForeColor is set then use that color

Risk

  • low

Screenshots

Before

image

After

image

Test methodology

  • manual
Microsoft Reviewers: Open in CodeFlow

@Epica3055 Epica3055 requested a review from a team as a code owner September 12, 2025 02:00
@github-actions github-actions bot added the area-DarkMode Issues relating to Dark Mode feature label Sep 12, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 12, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 77.12333%. Comparing base (04dbda2) to head (53b5874).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #13863         +/-   ##
===================================================
+ Coverage   77.11833%   77.12333%   +0.00499%     
===================================================
  Files           3273        3273                 
  Lines         644931      644919         -12     
  Branches       47692       47693          +1     
===================================================
+ Hits          497360      497383         +23     
+ Misses        143900      143866         -34     
+ Partials        3671        3670          -1     
Flag Coverage Δ
Debug 77.12333% <0.00000%> (+0.00499%) ⬆️
integration 18.99252% <0.00000%> (+0.00393%) ⬆️
production 51.96101% <0.00000%> (+0.01015%) ⬆️
test 97.41256% <ø> (ø)
unit 49.37389% <0.00000%> (+0.00866%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

LeafShi1
LeafShi1 previously approved these changes Sep 12, 2025
@ricardobossan
Copy link
Copy Markdown
Member

All LGTM.

Copy link
Copy Markdown
Member

@KlausLoeffelmann KlausLoeffelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@LeafShi1 LeafShi1 merged commit 6b3cb93 into dotnet:main Sep 19, 2025
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-DarkMode Issues relating to Dark Mode feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The custom ForeColor set on PrintPreviewControl is not rendered correctly

4 participants