Skip to content

Update language format from ll_CC to LCID#9566

Merged
dreddy-work merged 4 commits intodotnet:mainfrom
dreddy-work:updateresources
Jul 26, 2023
Merged

Update language format from ll_CC to LCID#9566
dreddy-work merged 4 commits intodotnet:mainfrom
dreddy-work:updateresources

Conversation

@dreddy-work
Copy link
Copy Markdown
Member

@dreddy-work dreddy-work commented Jul 25, 2023

Related to #9556

loc team says ll-CC format is not working for some reason and suggested to change the format to LCID.

Microsoft Reviewers: Open in CodeFlow

@dreddy-work dreddy-work requested a review from a team as a code owner July 25, 2023 21:19
@ghost ghost assigned dreddy-work Jul 25, 2023
@dreddy-work dreddy-work requested a review from danyeh July 25, 2023 21:20
@elachlan
Copy link
Copy Markdown
Contributor

CC: @DJm00n

@dreddy-work aren't LCIDs deprecated?

@dreddy-work
Copy link
Copy Markdown
Member Author

dreddy-work commented Jul 25, 2023

@dreddy-work aren't LCIDs deprecated?

LCIDs in this PR are used for Loc translation by an internal tool. The way our pipeline setup, it seems loc tools confused between fr and fr-FR and suggested us to use LCID instead, to avoid it.

@elachlan
Copy link
Copy Markdown
Contributor

This will be a pain to maintain in the future. Is it possible to raise an issue to change it back once the internal tool's issue is resolved?

@Tanya-Solyanik
Copy link
Copy Markdown
Contributor

Please get an approval from the loc team

Tanya-Solyanik
Tanya-Solyanik previously approved these changes Jul 26, 2023
@dreddy-work
Copy link
Copy Markdown
Member Author

dreddy-work commented Jul 26, 2023

This will be a pain to maintain in the future. Is it possible to raise an issue to change it back once the internal tool's issue is resolved?

I don't expect these files to change except for adding new strings. And we do not use Locked attribute on new strings. Regarding the deprecation of LCIDs, where did you read it? LCIDs are used all over .NET (language specific URLs for documentation or product download redirections use them)

@elachlan
Copy link
Copy Markdown
Contributor

elachlan commented Jul 26, 2023

It was mentioned in #8573.

It was under: https://learn.microsoft.com/en-us/globalization/locale/standard-locale-names#the-deprecation-of-lcids

But it looks like that was removed? I can't find it via wayback archive.org

Edit: another link: https://learn.microsoft.com/en-us/globalization/locale/other-locale-names

@DJm00n
Copy link
Copy Markdown
Contributor

DJm00n commented Jul 26, 2023

@dreddy-work

it seems loc tools confused between fr and fr-FR and suggested us to use LCID instead, to avoid it.

maybe you can just use LCID for this fr case alone then? anywayszh-Hant language tag is preserved in your change...

@DJm00n
Copy link
Copy Markdown
Contributor

DJm00n commented Jul 26, 2023

@dreddy-work

Regarding the deprecation of LCIDs, where did you read it? LCIDs are used all over .NET (language specific URLs for documentation or product download redirections use them)

Here:

LCIDs are being deprecated, and implementers are strongly encouraged to use locale names instead. LCIDs can be used for backward compatibility, but as noted in section 2.2.1, there is no guarantee of LCID uniqueness when used with valid locale names not otherwise associated with an LCID.

and also dotnet/runtime#82367 (comment)

@dreddy-work dreddy-work enabled auto-merge (squash) July 26, 2023 18:30
@dreddy-work dreddy-work merged commit 1063cca into dotnet:main Jul 26, 2023
@ghost ghost added this to the 8.0 RC1 milestone Jul 26, 2023
@dreddy-work dreddy-work deleted the updateresources branch August 1, 2023 00:50
@ghost ghost locked as resolved and limited conversation to collaborators Aug 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants