Merged
Conversation
JeremyKuhne
requested changes
Sep 5, 2023
Member
JeremyKuhne
left a comment
There was a problem hiding this comment.
Added a few comments. We probably should convert STG_* into a StorageType enum and add something for PropertyBag.
| @@ -2812,35 +2826,36 @@ private void DepersistControl() | |||
| // Must init new: | |||
| if (_instance is IPersistStreamInit.Interface init) | |||
Member
There was a problem hiding this comment.
All of these is checks need to go away. You need to query for the desired interface pointer.
JeremyKuhne
reviewed
Sep 6, 2023
src/System.Windows.Forms/src/System/Windows/Forms/AxHost.StorageType.cs
Outdated
Show resolved
Hide resolved
JeremyKuhne
reviewed
Sep 6, 2023
JeremyKuhne
reviewed
Sep 6, 2023
JeremyKuhne
reviewed
Sep 6, 2023
JeremyKuhne
reviewed
Sep 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StorageTypeenumto track what interface_instanceisT.Interfacefields inAxHostand query interface on_instancebased onStorageTypeStorageType.PropertyBagwhere appropriate. We never explicitly defined this before, but were essentially following the same pattern as the other storage casesAxHost.DepersistControlAxHost.Stateto use pointers instead ofT.Interface