Fix folder browser code#9866
Merged
JeremyKuhne merged 1 commit intodotnet:release/8.0from Sep 8, 2023
Merged
Conversation
The old style folder browser was broken a few different ways: - FolderBrowserDialog would not return the result - FolderNameEditor would AV - All were leaking shell handles This adds a centralized helper to avoid these problems. This also: - Moves the exception string to primitives - Uses CSIDL defines and clarifies usage - Unblocks other CSIDL values - Uses the updated API to get the path from the PIDL We can't use the shared dialog in FolderNameEditor as we expose dialog styles there that are not exposed in FolderBrowserDialog. Fixes dotnet#9859
Member
Author
|
Manually validated |
Member
Author
|
I'm going to cherry pick this back to main as there are conflicts. |
Contributor
|
Where was the AV? |
Member
Author
@Tanya-Solyanik Yes, there. We were also pinning |
Tanya-Solyanik
approved these changes
Sep 8, 2023
JeremyKuhne
added a commit
to JeremyKuhne/winforms
that referenced
this pull request
Sep 8, 2023
The old style folder browser was broken a few different ways: - FolderBrowserDialog would not return the result - FolderNameEditor would AV - All were leaking shell handles This adds a centralized helper to avoid these problems. This also: - Moves the exception string to primitives - Uses CSIDL defines and clarifies usage - Unblocks other CSIDL values - Uses the updated API to get the path from the PIDL We can't use the shared dialog in FolderNameEditor as we expose dialog styles there that are not exposed in FolderBrowserDialog. Fixes dotnet#9859
JeremyKuhne
added a commit
that referenced
this pull request
Sep 8, 2023
Fix folder browser code (#9866)
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old style folder browser was broken a few different ways:
This adds a centralized helper to avoid these problems. This also:
We can't use the shared dialog in FolderNameEditor as we expose dialog styles there that are not exposed in FolderBrowserDialog.
Fixes #9859