Skip to content

feat(UniverSheet): add auto switch darkmode function#7391

Merged
ArgoZhang merged 2 commits intomainfrom
feat-univer
Dec 22, 2025
Merged

feat(UniverSheet): add auto switch darkmode function#7391
ArgoZhang merged 2 commits intomainfrom
feat-univer

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Dec 22, 2025

Link issues

fixes #7390

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

New Features:

  • Allow UniverSheet in the sample page to automatically follow the default or ambient dark mode setting.

Copilot AI review requested due to automatic review settings December 22, 2025 06:14
@bb-auto bb-auto bot added the enhancement New feature or request label Dec 22, 2025
@bb-auto bb-auto bot added this to the v10.1.0 milestone Dec 22, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 22, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Removes the hard-coded IsDarkMode flag from the UniverSheet sample so the component can use its built-in automatic dark mode behavior.

Sequence diagram for automatic dark mode switching in UniverSheet

sequenceDiagram
  actor User
  participant Browser
  participant AppLayout
  participant ThemeService
  participant UniverSheet

  User->>Browser: Load_UniverSheet_sample_page
  Browser->>AppLayout: Initialize_page
  AppLayout->>ThemeService: Get_current_theme
  ThemeService-->>AppLayout: theme_state
  AppLayout->>UniverSheet: Render_without_IsDarkMode_parameter

  User->>AppLayout: Toggle_dark_mode
  AppLayout->>ThemeService: Set_theme(dark)
  ThemeService-->>AppLayout: theme_updated
  AppLayout->>Browser: Apply_dark_theme_styles
  Browser->>UniverSheet: Propagate_theme_change
  UniverSheet-->>Browser: Re_render_in_dark_mode

  User->>AppLayout: Toggle_light_mode
  AppLayout->>ThemeService: Set_theme(light)
  ThemeService-->>AppLayout: theme_updated
  AppLayout->>Browser: Apply_light_theme_styles
  Browser->>UniverSheet: Propagate_theme_change
  UniverSheet-->>Browser: Re_render_in_light_mode
Loading

Class diagram for UniverSheets sample usage after removing IsDarkMode

classDiagram
  class UniverSheetsPage {
    - _sheetExcel UniverSheet
    - _jsonData string
    OnReadyAsync()
    OnSaveExcelData()
  }

  class UniverSheet {
    + RibbonType UniverSheetRibbonType
    + OnReadyAsync()
    + AutoDetectDarkMode()
  }

  class UniverSheetRibbonType {
  }

  UniverSheetsPage --> UniverSheet : uses
  UniverSheet --> UniverSheetRibbonType : configures
Loading

File-Level Changes

Change Details Files
Enable UniverSheet sample to use automatic dark mode detection instead of forcing light mode.
  • Remove the explicit IsDarkMode="false" parameter from the UniverSheet component usage so the default behavior can apply
  • Keep other UniverSheet parameters (reference, ready callback, ribbon type) unchanged to avoid behavioral regressions in the sample
src/BootstrapBlazor.Server/Components/Samples/UniverSheets.razor

Assessment against linked issues

Issue Objective Addressed Explanation
#7390 Implement automatic dark mode switching behavior for the UniverSheet component (so it no longer relies on a fixed IsDarkMode setting).

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ArgoZhang ArgoZhang merged commit 799d0b2 into main Dec 22, 2025
5 of 6 checks passed
@ArgoZhang ArgoZhang deleted the feat-univer branch December 22, 2025 06:14
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds auto-switching dark mode functionality to the UniverSheet component by upgrading to version 10.0.5 of the BootstrapBlazor.UniverSheet package and removing the explicit IsDarkMode="false" parameter from the demo component.

Key Changes:

  • Removed hardcoded dark mode setting to enable automatic dark mode detection
  • Updated BootstrapBlazor.UniverSheet package from version 10.0.4 to 10.0.5

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/BootstrapBlazor.Server/Components/Samples/UniverSheets.razor Removed the IsDarkMode="false" parameter from the UniverSheet component to enable auto-switching of dark mode
src/BootstrapBlazor.Server/BootstrapBlazor.Server.csproj Updated BootstrapBlazor.UniverSheet package version from 10.0.4 to 10.0.5 to support the new auto dark mode feature

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

</section>
<div class="bb-sheet-demo">
<UniverSheet @ref="_sheetExcel" OnReadyAsync="OnReadyAsync" RibbonType="UniverSheetRibbonType.Default" IsDarkMode="false"></UniverSheet>
<UniverSheet @ref="_sheetExcel" OnReadyAsync="OnReadyAsync" RibbonType="UniverSheetRibbonType.Default"></UniverSheet>
Copy link

Copilot AI Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The IsDarkMode parameter has been removed from this component instance to enable auto-switching of dark mode. However, the localization files (en-US.json and zh-CN.json) at line 7015 still reference the IsDarkMode parameter in the NormalDescDarkMode key, stating it controls whether the component uses dark mode. This documentation should be updated to reflect the new auto-switching behavior instead of mentioning a parameter that is no longer being used in the demo.

Copilot uses AI. Check for mistakes.
@codecov
Copy link

codecov bot commented Dec 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (7190674) to head (fc150ad).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #7391   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          748       748           
  Lines        32793     32793           
  Branches      4551      4551           
=========================================
  Hits         32793     32793           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(UniverSheet): add auto switch darkmode function

2 participants