Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements trusted publishing for both npm and Cargo (crates.io) packages, migrating from token-based authentication to OIDC-based authentication. The changes remove publishing logic from the CI workflow and create a dedicated publish workflow that uses GitHub Actions OIDC tokens for secure, automated publishing.
Key Changes:
- Created a new
.github/workflows/publish.ymlworkflow with OIDC-based publishing for both Cargo and npm - Enhanced
deployment/npm/setup.jsto support syncing version fromCargo.tomlusing async-versionargument - Removed manual publishing steps from the CI workflow
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/publish.yml |
New workflow implementing trusted publishing for both Cargo (using rust-lang/crates-io-auth-action@v1) and npm packages with OIDC tokens |
deployment/npm/setup.js |
Added sync-version mode to automatically extract and sync version from Cargo.toml instead of requiring manual version argument |
.github/workflows/ci.yml |
Removed npm and Cargo publish steps from CI, updated to Node.js 24.x, and simplified setup.js call (no version argument) for testing |
.github/workflows/release.yml |
Updated actions/checkout from v5 to v6 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.