Skip to content

[11433429160] Fix PR scope review failing on large diffs#4

Merged
TheDokT0r merged 5 commits intomasterfrom
feature/11433429160-fix-pr-scope-output-limit
Mar 12, 2026
Merged

[11433429160] Fix PR scope review failing on large diffs#4
TheDokT0r merged 5 commits intomasterfrom
feature/11433429160-fix-pr-scope-output-limit

Conversation

@TheDokT0r
Copy link
Contributor

@TheDokT0r TheDokT0r commented Mar 12, 2026

🔗 Monday Ticket: https://shapes.monday.com/boards/18400257730/pulses/11433429160

Summary

  • Fix large diff crash: Write PR diff to $RUNNER_TEMP file instead of $GITHUB_OUTPUT heredoc — fixes "Matching delimiter not found" error when diffs exceed GitHub Actions output variable size limits
  • Fix control characters in diffs: Use jq --rawfile instead of jq --arg with shell variable expansion — prevents JSON parse errors on diffs containing binary/control characters
  • Fix duplicate comment detection: Replace --paginate + jq length (runs per page, returns multi-line output breaking the -gt comparison) with grep -c . which correctly counts across pages
  • Make non-blocking: Add continue-on-error: true so the scope review never blocks PR merging — it only posts advisory comments

Context

The workflow was failing on dreamteam-io-server PR #1930 with a 120KB diff that exceeded GITHUB_OUTPUT limits.

Test plan

  • Verified jq --rawfile handles real PR #1930 diff with control characters (120KB)
  • Verified grep -c . returns 0 on empty output (no false positives)
  • Verified workflow syntax with act dry run
  • Merge and confirm server PR #1930 scope review passes

🤖 Generated with Claude Code

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

@TheDokT0r TheDokT0r merged commit c3c495f into master Mar 12, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants