Build fails on FreeBSD: error: redefinition of 'addrinfo'

[yurivict]

What happens?

In file included from /usr/ports/databases/duckdb/work/duckdb-1.4.4/extension/postgres_scanner/postgres/src/common/ip.c:37:
In file included from /usr/ports/databases/duckdb/work/duckdb-1.4.4/extension/postgres_scanner/postgres/src/include/common/ip.h:17:
/usr/ports/databases/duckdb/work/duckdb-1.4.4/extension/postgres_scanner/postgres/src/include/getaddrinfo.h:98:8: error: redefinition of 'addrinfo'
   98 | struct addrinfo
      |        ^
/usr/include/netdb.h:133:8: note: previous definition is here
  133 | struct addrinfo {
      |        ^
In file included from /usr/ports/databases/duckdb/work/duckdb-1.4.4/extension/postgres_scanner/postgres/src/common/ip.c:37:
In file included from /usr/ports/databases/duckdb/work/duckdb-1.4.4/extension/postgres_scanner/postgres/src/include/common/ip.h:18:
/usr/ports/databases/duckdb/work/duckdb-1.4.4/extension/postgres_scanner/postgres/src/include/libpq/pqcomm.h:44:8: error: redefinition of 'sockaddr_storage'
   44 | struct sockaddr_storage
      |        ^
/usr/include/sys/_sockaddr_storage.h:45:8: note: previous definition is here
   45 | struct sockaddr_storage {
      |        ^
2 errors generated.

These structures are re-defined in the downloaded code tarball and structures are different.

To Reproduce

Build on FreeBSD.

OS:

FreeBSD 15 STABLE

PostgreSQL Version:

N/A

DuckDB Version:

1.4.4

DuckDB Client:

1.4.4

Full Name:

Yuri Vic

Affiliation:

FreeBSD

Have you tried this on the latest main branch?

• I agree

Have you tried the steps to reproduce? Do they include all relevant data and configuration? Does the issue you report still appear there?

• I agree

[3dfxScorpion]

RE: Bug 292757

Hi @yurivict,

FreeBSD Build Success - Working Patches Available

I've successfully built DuckDB 1.4.4 with postgres_scanner on FreeBSD 14.3 and have it working! The issues reported here are solvable with the following patches.

Required Changes:

1. Port Makefile - Add to CFLAGS:

CFLAGS+= -DHAVE_STRUCT_ADDRINFO=1 \
         -DHAVE_STRUCT_SOCKADDR_STORAGE=1 \
         -DHAVE_STRUCT_SOCKADDR_STORAGE_SS_FAMILY=1 \
         -DHAVE_GETADDRINFO=1

2. CMakeLists.txt patch:
   Create files/patch-extension_postgres__scanner_CMakeLists.txt:

--- extension/postgres_scanner/CMakeLists.txt.orig
+++ extension/postgres_scanner/CMakeLists.txt
@@ -4,9 +4,12 @@
 
 add_definitions(-DFRONTEND=1 -D_GNU_SOURCE=1)
 add_definitions(-DUSE_OPENSSL=1 -DHAVE_BIO_GET_DATA=1 -DHAVE_BIO_METH_NEW=1)
+add_definitions(-DLOCALEDIR="/usr/local/share/locale")
 set(OPENSSL_USE_STATIC_LIBS TRUE)
 
 find_package(OpenSSL REQUIRED)
+find_library(INTL_LIBRARY NAMES intl PATHS /usr/local/lib REQUIRED)
+message(STATUS "Found libintl: ${INTL_LIBRARY}")
 
 if(NOT MSVC)
   set(POSTGRES_SCANNER_EXTRA_CFLAGS
@@ -78,6 +81,11 @@
   set(LIBPG_SOURCES ${LIBPG_SOURCES} postgres/src/port/strlcpy.c
                     postgres/src/port/getpeereid.c)
 endif()
+
+# FreeBSD needs pqsignal.c for pqsignal_fe symbol
+if(CMAKE_SYSTEM_NAME STREQUAL "FreeBSD")
+  set(LIBPG_SOURCES ${LIBPG_SOURCES} postgres/src/port/pqsignal.c)
+endif()
 
 if(WIN32)
   set(LIBPG_SOURCES
@@ -187,6 +195,7 @@
 endif()
 
 set(PARAMETERS "-no-warnings")
+build_static_extension(${TARGET_NAME} ${LIBPG_SOURCES_FULLPATH} ${ALL_OBJECT_FILES})
 build_loadable_extension(${TARGET_NAME} ${PARAMETERS} ${ALL_OBJECT_FILES}
                          ${LIBPG_SOURCES_FULLPATH})
 
@@ -201,6 +210,9 @@
 endif()
 
 target_link_libraries(${TARGET_NAME}_loadable_extension ${OPENSSL_LIBRARIES})
+target_link_libraries(${TARGET_NAME}_loadable_extension ${INTL_LIBRARY})
+target_link_libraries(${TARGET_NAME}_extension ${OPENSSL_LIBRARIES})
+target_link_libraries(${TARGET_NAME}_extension ${INTL_LIBRARY})
 set_property(TARGET ${TARGET_NAME}_loadable_extension PROPERTY C_STANDARD 99)
 
 if(WIN32)
@@ -204,3 +216,9 @@
   target_link_libraries(${TARGET_NAME}_loadable_extension wsock32 ws2_32
                         wldap32 secur32 crypt32)
 endif()
+
+install(
+  TARGETS ${TARGET_NAME}_extension
+  EXPORT "${DUCKDB_EXPORT_SET}"
+  LIBRARY DESTINATION "${INSTALL_LIB_DIR}"
+  ARCHIVE DESTINATION "${INSTALL_LIB_DIR}”)

What This Fixes:

• Header redefinitions (addrinfo, sockaddr_storage)
• Missing LOCALEDIR definition
• Missing static library build for postgres_scanner
• Missing libintl linking
• Missing pqsignal_fe symbol

Tested On:

• FreeBSD 14.3-RELEASE
• PostgreSQL 17.7
• DuckDB 1.4.4
• Clang 19.1.7

postgres_scanner now works and successfully connects to PostgreSQL databases. Hope this is helpful!

—Derrick
Note: troubleshooting, development, testing, and reporting assisted with A.I. Then again, what isn’t these days...