feat: add quirk to dedup and sort sequence sets during encoding#691
feat: add quirk to dedup and sort sequence sets during encoding#691soywod wants to merge 4 commits intoduesee:mainfrom
Conversation
db3f422 to
bb9e0f5
Compare
bb9e0f5 to
d69ebe4
Compare
|
Looks like the feature breaks things, I will need more time to adjust. I would like to know first if you agree with the proposition. |
|
This is going in the right direction! I think that our structured fuzzer will break due to this, but I propose we first don't care about that here. We should maybe add an issue to also account for this quirk during fuzzing but I can take care of that later. Thanks to your unit tests, I think that we can make the best of this quirk by making it a nice generic feature. Curious what you think. By the way, I'll be on vacation for a fee weeks. But I'll try to have a look here now and then. |
4351bcb to
71f5ba0
Compare
|
I pushed a new version in another commit so you can see the difference. I will squash before merging. I moved the logic into
|
|
I also added more cases to the normalization, for exemple range a:a to single a, single asterisk to range 1:asterisk (because not all IMAP server like the |
Pull Request Test Coverage Report for Build 21943312117Details
💛 - Coveralls |
|
Ready for another review. I am not so happy about the implementation, but I don't see yet how to improve it. |
01cc5e1 to
3ce5a4b
Compare
3ce5a4b to
49a1074
Compare
|
Finally, CI happy 😄 |
|
Wow! This looks so much better! Thanks! Let me do a proper review tomorrow evening :-) |
duesee
left a comment
There was a problem hiding this comment.
I believe there is still an improvement to make so that x:y,y:z is merged into x:z. But since this is a vast improvement already (and I know that you need the change :-)), I'll let you decide to merge as is. Can do a release later today.
|
A condition was not properly set, see cfba643. Now it merges properly contiguous ranges. Ready for another review. |
Closes #689.