feat: add autoSelectFamily for happy eyeballs support#99
Merged
dwmkerr merged 1 commit intodwmkerr:mainfrom Sep 20, 2023
Merged
feat: add autoSelectFamily for happy eyeballs support#99dwmkerr merged 1 commit intodwmkerr:mainfrom
dwmkerr merged 1 commit intodwmkerr:mainfrom
Conversation
Owner
|
Looks great, thanks @acmacalister ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some environments, waiting on localhost can cause it to pick either ipv6 or ipv4 which can cause issue with certain sets of software (namely Docker network bridges which are exposed on ipv4 only). That being said, Node add Happy Eyeball support in nodejs/node#44731, which was released in Node 18, the currently support LTS. This PR adds the
autoSelectFamilyoption to support said environments. Let me know if you have any questions. Thanks!npx wait-port 1132