Conversation
OliverWoolland
previously approved these changes
Feb 18, 2026
EttoreM
reviewed
Feb 25, 2026
EttoreM
left a comment
EttoreM
left a comment
There was a problem hiding this comment.
- The PR description says a dictionary object is passed for validation, but it looks like we’re actually passing a stringified JSON object. Is that intentional?
EttoreM
requested changes
Feb 25, 2026
EttoreM
left a comment
EttoreM
left a comment
There was a problem hiding this comment.
It seems to me that you need to pass profile_path to the function queue_ro_crate_metadata_validation_task inside the POST endpoint /validate_metadata, and then propagate it throughout subsequent calls.
Collaborator
Author
This is my laziness. I'll update the PR description. |
douglowe
deleted the
103-update-metadata-only-function-to-match-rocrate-validator-features
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the metadata only validation function, so that we pass this directly into the validator as a string containing a JSON object. The test suite has been updated to reflect this change, and the file utilities library removed, as we no longer need to create an empty RO-Crate folder.