Alternative way to do manifest split without caching the splits#1498
Merged
Alternative way to do manifest split without caching the splits#1498
Conversation
dcherian
reviewed
Dec 22, 2025
dcherian
reviewed
Dec 22, 2025
dcherian
reviewed
Dec 22, 2025
dcherian
reviewed
Dec 22, 2025
dcherian
reviewed
Dec 22, 2025
paraseba
force-pushed
the
push-tqnxskxkzzqy
branch
from
0e87c2d to
d358153
Compare
dcherian
reviewed
Feb 24, 2026
dcherian
reviewed
Feb 24, 2026
| } | ||
| } | ||
|
|
||
| self.write_manifest_from_iterator(stream::iter(all_chunks_vec).err_into()).await |
Contributor
There was a problem hiding this comment.
could stream here instead of realizing a Vec. Is this where you had lifetime issues?
Collaborator
Author
There was a problem hiding this comment.
Yeah, basically, I'd have to replace the mutable for loops by a bunch of then, filter_map and others. I tried and failed. I think what is to blame is Manifest.iter() which is one of these weird things that take self as an Arc.
We should revisit if we find problems once we go into benchmarking.
li-em
approved these changes
Feb 24, 2026
Contributor
li-em
left a comment
li-em
left a comment
There was a problem hiding this comment.
This is so much cleaner now, thanks Seba!
| // With IC1, doing this correctly requires updating Session.splits during rebase to match the new | ||
| // parent snapshot's array shapes. | ||
| async fn test_rebase_over_resize() -> Result<(), Box<dyn Error>> { | ||
| struct YoloSolver; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.