Merged
Conversation
- Initiate method has been fixed
- Initiate method has been fixed --- <details open="true"><summary>Generated summary (powered by <a href="https://app.graphite.dev">Graphite</a>)</summary> > ## TL;DR > This pull request modifies the `ReferenceQuadrangle_Method@Methods.F90` file to fix an issue with the `InterpolationPoint_Quadrangle` function call. The `xij` parameter now correctly uses the entire `refelem%xij` array instead of a subset. > > ## What changed > In the `ReferenceQuadrangle_Method@Methods.F90` file, the `InterpolationPoint_Quadrangle` function call was modified. Previously, it was using a subset of the `refelem%xij` array (`refelem%xij(1:3, 1:4)`). Now, it uses the entire array (`refelem%xij`). > > ```diff > - & xij=refelem%xij(1:3, 1:4), & > + & xij=refelem%xij, & > ``` > > ## How to test > To test this change, you can run the existing unit tests for the `ReferenceQuadrangle_Method@Methods.F90` file. If the tests pass, it indicates that the change is working as expected. If there are no existing tests, consider adding some to verify the correct behavior of the `InterpolationPoint_Quadrangle` function call. > > ## Why make this change > This change is necessary because the previous code was not using the entire `refelem%xij` array, which could lead to incorrect results. By using the entire array, we ensure that the `InterpolationPoint_Quadrangle` function has all the necessary data to perform its calculations correctly. </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing bug in ReferenceQuadrangle_Method higher order element