fix: Implement zero as limit for getAllSubmodels#1000
Merged
aaronzi merged 1 commit intoeclipse-basyx:mainfrom Apr 23, 2026
Merged
fix: Implement zero as limit for getAllSubmodels#1000aaronzi merged 1 commit intoeclipse-basyx:mainfrom
aaronzi merged 1 commit intoeclipse-basyx:mainfrom
Conversation
Signed-off-by: Linus Schöler <linus@schoeler.de>
aaronzi
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description of Changes
Implemented zero as limit for getAllSubmodels and getAllSubmodelElements API endpoints. Minimum value has been changed from 1 to 0, enabling the call "/submodels?limit=0" to return the full list of Submodels. This mirrors the existing "/shells?limit=0" behavior introduced in commit 770a65f
Related Issue
None
BaSyx Configuration for Testing
I used an env with >100 Submodels. "/submodels?limit=0" returns all of the submodels. Same as "/submodels?limit=99999"