Adds ca-certificates installation step to Dockerfiles#941
Merged
aaronzi merged 7 commits intoeclipse-basyx:mainfrom Dec 18, 2025
Merged
Adds ca-certificates installation step to Dockerfiles#941aaronzi merged 7 commits intoeclipse-basyx:mainfrom
aaronzi merged 7 commits intoeclipse-basyx:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds ca-certificates installation to multiple Dockerfiles across the BaSyx project to ensure SSL/TLS certificate validation works correctly. The changes also introduce HTTP_PROXY and HTTPS_PROXY build arguments to some Dockerfiles.
Key changes:
- Installation of ca-certificates package in all component Dockerfiles using apt-get
- Addition of HTTP_PROXY and HTTPS_PROXY arguments to Dockerfiles that didn't previously have them
- Introduction of USER root directive before package installation, followed by USER nobody in applicable files
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 17 comments.
Show a summary per file
| File | Description |
|---|---|
| basyx.submodelservice/basyx.submodelservice.example/Dockerfile | Adds USER root, ca-certificates installation, and maintains USER nobody switch |
| basyx.submodelservice/basyx.submodelservice.component/Dockerfile | Adds proxy args to maven-downloader stage and ca-certificates installation with USER directives |
| basyx.submodelrepository/basyx.submodelrepository.component/Dockerfile | Adds USER root, ca-certificates installation, and maintains USER nobody switch |
| basyx.submodelregistry/basyx.submodelregistry-service-release-log-mongodb/src/main/docker/Dockerfile | Adds USER root and ca-certificates installation without switching back to non-root user |
| basyx.submodelregistry/basyx.submodelregistry-service-release-log-mem/src/main/docker/Dockerfile | Adds USER root and ca-certificates installation without switching back to non-root user |
| basyx.submodelregistry/basyx.submodelregistry-service-release-kafka-mongodb/src/main/docker/Dockerfile | Adds USER root and ca-certificates installation without switching back to non-root user |
| basyx.submodelregistry/basyx.submodelregistry-service-release-kafka-mem/src/main/docker/Dockerfile | Adds USER root and ca-certificates installation without switching back to non-root user |
| basyx.submodelregistry/basyx.submodelregistry-feature-hierarchy-example/src/main/docker/Dockerfile | Adds proxy args to both stages and ca-certificates installation without switching back to non-root user; removes trailing newline |
| basyx.conceptdescriptionrepository/basyx.conceptdescriptionrepository.component/Dockerfile | Adds USER root, ca-certificates installation, and maintains USER nobody switch |
| basyx.aasxfileserver/basyx.aasxfileserver.component/Dockerfile | Adds USER root, ca-certificates installation, and maintains USER nobody switch |
| basyx.aasrepository/basyx.aasrepository.component/Dockerfile | Adds USER root, ca-certificates installation, and maintains USER nobody switch |
| basyx.aasregistry/basyx.aasregistry-service-release-log-mongodb/src/main/docker/Dockerfile | Adds USER root and ca-certificates installation without switching back to non-root user |
| basyx.aasregistry/basyx.aasregistry-service-release-log-mem/src/main/docker/Dockerfile | Adds USER root and ca-certificates installation without switching back to non-root user |
| basyx.aasregistry/basyx.aasregistry-service-release-kafka-mongodb/src/main/docker/Dockerfile | Adds USER root and ca-certificates installation without switching back to non-root user |
| basyx.aasregistry/basyx.aasregistry-service-release-kafka-mem/src/main/docker/Dockerfile | Adds proxy args and ca-certificates installation without switching back to non-root user; removes trailing newline |
| basyx.aasregistry/basyx.aasregistry-feature-hierarchy-example/src/main/docker/Dockerfile | Adds proxy args to both stages and ca-certificates installation without switching back to non-root user; removes trailing newline |
| basyx.aasenvironment/basyx.aasenvironment.component/Dockerfile | Adds USER root, ca-certificates installation, and maintains USER nobody switch |
| basyx.aasdiscoveryservice/basyx.aasdiscoveryservice.component/Dockerfile | Adds USER root, ca-certificates installation, and maintains USER nobody switch |
| basyx.aasdigitaltwinregistry/basyx.digitaltwinregistry.component/Dockerfile | Adds proxy args, USER root, ca-certificates installation, and maintains USER nobody switch |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aaronzi
requested changes
Dec 17, 2025
aaronzi
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Adds ca-certificates installation step to Dockerfiles