Added the possibility to create an empty workspace by olexii4 · Pull Request #602 · eclipse-che/che-dashboard

olexii4 · 2022-08-09T09:22:00Z

Signed-off-by: Oleksii Orel oorel@redhat.com

What does this PR do?

Added the possibility to create an empty workspace

What issues does this PR fix or reference?

fixes eclipse-che/che#21554

depends on eclipse-che/che-operator#1486

Is it tested? How?

Deploy CHE and open Create Workspace tab
Click on the Empty Workspace sample

The PR can be tested here: https://eclipse-che.apps.cluster-pdfv6.pdfv6.sandbox1498.opentlc.com/dashboard/

che-bot · 2022-08-09T09:22:15Z

Click here to review and test in web IDE:

github-actions · 2022-08-09T09:36:41Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-602

che-bot · 2022-08-09T09:49:56Z

Click here to review and test in web IDE:

github-actions · 2022-08-09T10:03:02Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-602

che-bot · 2022-08-09T12:47:38Z

Click here to review and test in web IDE:

github-actions · 2022-08-09T13:05:49Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-602

che-bot · 2022-08-09T13:32:50Z

Click here to review and test in web IDE:

github-actions · 2022-08-09T13:48:15Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-602

packages/dashboard-frontend/static/registry/devfiles/empty.yaml

che-bot · 2022-08-10T14:04:52Z

Click here to review and test in web IDE:

che-bot · 2022-08-10T14:06:27Z

Click here to review and test in web IDE:

github-actions · 2022-08-10T14:21:34Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-602

github-actions · 2022-08-10T14:21:57Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-602

che-bot · 2022-08-10T15:04:41Z

Click here to review and test in web IDE:

github-actions · 2022-08-10T15:19:12Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-602

Signed-off-by: Oleksii Orel <oorel@redhat.com>

che-bot · 2022-08-16T14:16:09Z

Click here to review and test in web IDE:

Signed-off-by: Oleksii Orel <oorel@redhat.com>

che-bot · 2022-08-16T14:37:42Z

Click here to review and test in web IDE:

github-actions · 2022-08-16T14:54:23Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-602

l0rd · 2022-08-16T15:08:04Z

I have tested this PR and it worked just fine. A few minor comments that can be addressed later:

The community label should be removed as it's not sourced from a community devfile registry
The description just says "Empty workspace" (as the title) and something like "Start an empty remote development environment and create files or clone a git repository afterwards" would be better
Instead of having one unique "Empty workspace" tile it would be better to have one tile per supported editor. For example for VS Code:
- Title: "VS Code remote dev environment"
- Description: "Start an empty VS Code based development environment and create files or clone a git repository afterwards"
- Icon: VS Code icon
Since those are special dev environemnts, I would have them on a dedicated row. In other words after the empty dev environments we should add a new line.

che-bot · 2022-08-17T09:12:19Z

Click here to review and test in web IDE:

che-bot · 2022-08-17T09:13:55Z

Click here to review and test in web IDE:

github-actions · 2022-08-17T09:28:30Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-602

github-actions · 2022-08-17T09:31:30Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-602

che-bot · 2022-08-17T12:39:39Z

Click here to review and test in web IDE:

github-actions · 2022-08-17T12:55:46Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-602

ibuziuk

Great job! verified locally against dogfooding
works like a charm 👍

che-bot · 2022-08-23T13:58:31Z

Click here to review and test in web IDE:

github-actions · 2022-08-23T14:15:00Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-602

…workspace

che-bot · 2022-08-23T14:16:43Z

Click here to review and test in web IDE:

openshift-ci · 2022-08-23T14:28:36Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

github-actions · 2022-08-23T14:35:20Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-602

openshift-ci · 2022-08-23T15:30:50Z

@olexii4: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/v8-dashboard-happy-path	`93a18e2`	link	true	`/test v8-dashboard-happy-path`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

nickboldt · 2022-12-14T22:39:31Z

This is also in Dev Spaces 3.3:

olexii4 requested a review from ibuziuk August 9, 2022 09:22

olexii4 requested a review from akurinnoy as a code owner August 9, 2022 09:22

olexii4 marked this pull request as draft August 9, 2022 10:43

openshift-ci bot added the do-not-merge/work-in-progress label Aug 9, 2022

olexii4 marked this pull request as ready for review August 9, 2022 12:48

openshift-ci bot removed the do-not-merge/work-in-progress label Aug 9, 2022

ibuziuk reviewed Aug 10, 2022

View reviewed changes

packages/dashboard-frontend/static/registry/devfiles/empty.yaml Outdated Show resolved Hide resolved

ibuziuk reviewed Aug 10, 2022

View reviewed changes

packages/dashboard-frontend/static/registry/devfiles/empty.yaml Outdated Show resolved Hide resolved

olexii4 force-pushed the CHE_21554 branch from 33a72be to 085061e Compare August 10, 2022 14:04

feat: add possibility to create an empty workspace

f83cf4a

Signed-off-by: Oleksii Orel <oorel@redhat.com>

olexii4 force-pushed the CHE_21554 branch from aa9de58 to ef48f51 Compare August 16, 2022 14:15

fix: remove old tests

df24158

Signed-off-by: Oleksii Orel <oorel@redhat.com>

olexii4 force-pushed the CHE_21554 branch from ef48f51 to df24158 Compare August 16, 2022 14:37

fixup! feat: add possibility to create an empty workspace

2b392be

olexii4 force-pushed the CHE_21554 branch from c6c51b4 to 2b392be Compare August 17, 2022 09:13

fixup! fixup! feat: add possibility to create an empty workspace

0a9a83a

ibuziuk approved these changes Aug 18, 2022

View reviewed changes

openshift-ci bot assigned ibuziuk Aug 18, 2022

openshift-ci bot added the lgtm label Aug 18, 2022

fixup! fixup! fixup! feat: add possibility to create an empty workspace

2f0e1ef

openshift-ci bot removed the lgtm label Aug 23, 2022

fixup! fixup! fixup! fixup! feat: add possibility to create an empty …

93a18e2

…workspace

akurinnoy approved these changes Aug 23, 2022

View reviewed changes

openshift-ci bot assigned akurinnoy Aug 23, 2022

openshift-ci bot added the lgtm label Aug 23, 2022

olexii4 merged commit b458703 into main Aug 23, 2022

olexii4 deleted the CHE_21554 branch August 23, 2022 19:01

che-bot added this to the 7.53 milestone Aug 23, 2022

devstudio-release mentioned this pull request Jan 17, 2023

Add an IDE-only workspace sample in the Dashboard getting started (without project) eclipse-che/che#21554

Closed

Conversation

olexii4 commented Aug 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

What issues does this PR fix or reference?

Is it tested? How?

Uh oh!

che-bot commented Aug 9, 2022

Uh oh!

github-actions bot commented Aug 9, 2022

Uh oh!

che-bot commented Aug 9, 2022

Uh oh!

github-actions bot commented Aug 9, 2022

Uh oh!

che-bot commented Aug 9, 2022

Uh oh!

github-actions bot commented Aug 9, 2022

Uh oh!

che-bot commented Aug 9, 2022

Uh oh!

github-actions bot commented Aug 9, 2022

Uh oh!

Uh oh!

Uh oh!

che-bot commented Aug 10, 2022

Uh oh!

che-bot commented Aug 10, 2022

Uh oh!

github-actions bot commented Aug 10, 2022

Uh oh!

github-actions bot commented Aug 10, 2022

Uh oh!

che-bot commented Aug 10, 2022

Uh oh!

github-actions bot commented Aug 10, 2022

Uh oh!

che-bot commented Aug 16, 2022

Uh oh!

che-bot commented Aug 16, 2022

Uh oh!

github-actions bot commented Aug 16, 2022

Uh oh!

l0rd commented Aug 16, 2022

Uh oh!

che-bot commented Aug 17, 2022

Uh oh!

che-bot commented Aug 17, 2022

Uh oh!

github-actions bot commented Aug 17, 2022

Uh oh!

github-actions bot commented Aug 17, 2022

Uh oh!

che-bot commented Aug 17, 2022

Uh oh!

github-actions bot commented Aug 17, 2022

Uh oh!

ibuziuk left a comment

Choose a reason for hiding this comment

Uh oh!

che-bot commented Aug 23, 2022

Uh oh!

github-actions bot commented Aug 23, 2022

Uh oh!

che-bot commented Aug 23, 2022

Uh oh!

openshift-ci bot commented Aug 23, 2022

Uh oh!

github-actions bot commented Aug 23, 2022

Uh oh!

openshift-ci bot commented Aug 23, 2022

Uh oh!

nickboldt commented Dec 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

olexii4 commented Aug 9, 2022 •

edited

Loading

nickboldt commented Dec 14, 2022 •

edited

Loading