Che workspaces fail to start with OpenShift Console samples

[l0rd]

Is your enhancement related to a problem? Please describe

If I try to start a v2 devfile in Che with DevWorkspace disabled it will fail. For example workspaces.openshift.com/#https://github.com/redhat-developer/devfile-sample.git.

That's problematic because OpenShift developer console has 4 examples with a devfile v2 at its root:

And those will fail to fail to open in Che when using OpenShift Developer Console topology link

Describe the solution you'd like

In the very short term, when DW is not enabled but the che-server returns a v2 devfile.yaml, we should use devfile v2 to v1 conversion lib used by Che-Theia.

• Support v2 devfiles with che-server by converting them into corresponding v1 devfiles #20644

In the long term, for those these 3 cases:

• if DW is enabled but the che-server returns a v1 devfile.yaml
• if che-server consider the devfile invalid
• if che-server cannot validate becuse the specVersion is not supported

warn the user (with a clear message that specifies that the problem is one of 3 above, a link to the problematic devfile and the possible workarounds) and ask if he prefers to interrupt workspace startup (and eventually fix the devfile) or discard the devfile content and move forward with the creation of the workspace.

[l0rd]

After discussion we came to the conclusion that this should be fixed dashboard side.

[sleshchenko]

If schema is valid v2 and DW is not enabled: start a workspace as if there was no devfile

well, I think the right solution here would be Florent's proposal, where we scan the repo and respect devfile.yaml, devfilev1.yaml depending on Che mode.
Applying empty devfile does not solve the issue in the flow but makes it less visible. In the end user's won't get IDE that will work well for their project.

If schema is invalid: start a workspace as if there was no devfile

I do not really agree with that.
If we take a deeper look on the cause: it's the issue that may appear because ODO/OpenShift console depends on one devfile v2 schemaVersions, and Che embeds itsown.
the proposed solution just hides the issue but don't solve it. The solution would be making Che Server depends on some central Schema provider to evaluate if schema is valid or not, the same could you ODO or OpenShift Console.

Anyway, I would not mix these issues together.

[l0rd]

I am ok with any solution for the problem described if it can be included in CRW 2.13 release.

The invalid schema problem can be addressed later.

[l0rd]

Discussed with @benoitf and @davidfestal:

In the very short term, when DW is not enabled but the che-server returns a v2 devfile.yaml, we should use devfile v2 to v1 conversion lib used by Che-Theia. @benoitf can you please provide a link to that library?

In the long term, for those these 3 cases:

• if DW is enabled but the che-server returns a v1 devfile.yaml
• if che-server consider the devfile invalid
• if che-server cannot validate becuse the specVersion

warn the user and ask if he prefers to interrupt workspace startup (and eventually fix the devfile) or discard the devfile content and move forward.

[benoitf]

https://github.com/eclipse-che/che-theia/blob/main/extensions/eclipse-che-theia-remote-impl-che-server/src/node/che-server-devfile-service-impl.ts#L591-L650

[benoitf]

And tests there https://github.com/eclipse-che/che-theia/blob/main/extensions/eclipse-che-theia-remote-impl-che-server/tests/node/che-server-devfile-service-impl.spec.ts