build: update GHA workflow config#900
Closed
sebthom wants to merge 2 commits intoeclipse-lsp4j:mainfrom
Closed
Conversation
- update URLs to reference documentation - test on MacOS ARM and Intel - update versions of github actions (checkout, setup-java) - parameterize validate job so that in case of errors an SSH debug session can be opened
sebthom
force-pushed
the
gha
branch
3 times, most recently
from
bb0c9ae to
0706b69
Compare
- Decouple JDK to run Gradle from the JDK used to compile/test. - Use Java toolchains to select JDK 11 for compilation. - Set javac --release 11 for consistent API/bytecode. - Launch Test tasks with the JDK 11 toolchain. - Keep sourceCompatibility for IDEs; omit targetCompatibility.
This was referenced Nov 14, 2025
jonahgraham
requested changes
Nov 14, 2025
Contributor
jonahgraham
left a comment
jonahgraham
left a comment
There was a problem hiding this comment.
I have split this out into #918 which includes these changes plus some others, in particular to allow build and test with Java 21 while still generating Java 11 bytecode.
| workflow_dispatch: | ||
| # https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#workflow_dispatch | ||
| inputs: | ||
| debug-with-ssh: |
Contributor
There was a problem hiding this comment.
I have left the SSH parts out of #918 - I don't understand full ramifications of such an inclusion. If you think this is important, please create a new focused PR with this.
| steps: | ||
| - name: "Show: GitHub context" | ||
| env: | ||
| GITHUB_CONTEXT: ${{ toJSON(github) }} |
Contributor
There was a problem hiding this comment.
I have left this out of #918 - the github context has some amount of secrets which GH replaces with *** but I don't understand the benefit of having this. If you think this is important, please create a new focused PR with this.
Same for env | sort below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.