perf: bound header buffers and reuse builders in StreamMessageProducer#903
Open
sebthom wants to merge 1 commit intoeclipse-lsp4j:mainfrom
Open
perf: bound header buffers and reuse builders in StreamMessageProducer#903sebthom wants to merge 1 commit intoeclipse-lsp4j:mainfrom
sebthom wants to merge 1 commit intoeclipse-lsp4j:mainfrom
Conversation
Replace nullable builders with reusable instances to reduce allocations during header scan; avoid repeated StringBuilder creation.
sebthom
force-pushed
the
StreamMessageProducer
branch
from
02118bf to
6b58645
Compare
jonahgraham
approved these changes
Nov 19, 2025
Contributor
jonahgraham
left a comment
jonahgraham
left a comment
There was a problem hiding this comment.
Following on from discussions in #902 it is not obvious that there are performance improvements here. However I like this change as it simplifies null analysis. I quite prefer final variables over non-final whenever possible 😄
I approve, but I am going to hold off submitting until conversations in #902 are resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace nullable builders with reusable instances to reduce allocations during header scan; avoid repeated StringBuilder creation.