classpathentry should respect pom resource excludes/includes#1625
classpathentry should respect pom resource excludes/includes#1625qxo wants to merge 3 commits intoeclipse-m2e:mainfrom
Conversation
HannesWell
force-pushed
the
feat-classpathentry-excluding
branch
from
f45c317 to
1e4fa5d
Compare
Test Results 214 files ±0 214 suites ±0 15m 53s ⏱️ - 6m 7s For more details on these failures, see this check. Results for commit 55afb02. ± Comparison against base commit 369b34f. ♻️ This comment has been updated with latest results. |
HannesWell
left a comment
HannesWell
left a comment
There was a problem hiding this comment.
Hello @qxo, thank you for providing this PR.
In general this change looks reasonable, but we have to work through a few things until it can be considered for submission.
First of all, you have to sign the Eclipse Contributor Agreement, otherwise we are not allowed to accept your change.
Second please add a test-case to org.eclipse.m2e.jdt.tests in order to demonstrate the missing feature and to ensure it will continue to work in the future.
About the change itself, please see the remarks below.
org.eclipse.m2e.jdt/src/org/eclipse/m2e/jdt/internal/AbstractJavaProjectConfigurator.java
Outdated
Show resolved
Hide resolved
org.eclipse.m2e.jdt/src/org/eclipse/m2e/jdt/internal/AbstractJavaProjectConfigurator.java
Outdated
Show resolved
Hide resolved
qxo
force-pushed
the
feat-classpathentry-excluding
branch
2 times, most recently
from
1cb6b9e to
a3a9641
Compare
HannesWell
force-pushed
the
feat-classpathentry-excluding
branch
from
a3a9641 to
55afb02
Compare
qxo
force-pushed
the
feat-classpathentry-excluding
branch
from
55afb02 to
40a80f4
Compare
excludes/includes,: so we build project on eclipse without org.eclipse.m2e.core.maven2Builder
akurtakov
force-pushed
the
feat-classpathentry-excluding
branch
from
40a80f4 to
e0994ec
Compare
2 participants
so we build project on eclipse without org.eclipse.m2e.core.maven2Builder