fix: Prevent NullPointerException in Sw360ProjectService#3709
Merged
GMishx merged 1 commit intoeclipse-sw360:mainfrom Feb 23, 2026
Merged
fix: Prevent NullPointerException in Sw360ProjectService#3709GMishx merged 1 commit intoeclipse-sw360:mainfrom
GMishx merged 1 commit intoeclipse-sw360:mainfrom
Conversation
Changed oblLevel.equalsIgnoreCase(...) to "Project".equalsIgnoreCase(oblLevel) to avoid NPE when oblLevel parameter is null. This is a standard Java idiom - by putting the constant string first, if oblLevel is null, it returns false instead of throwing NPE. Fixes eclipse-sw360#3706
ADITYA-CODE-SOURCE
requested review from
GMishx,
KoukiHama,
ag4ums and
arunazhakesan
as code owners
Member
|
@ADITYA-CODE-SOURCE your future PRs will not be reviewed unless they follow the communities template. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed potential NullPointerException in Sw360ProjectService.setObligationsFromAdminSection method.
Changes
Changed from:
To:
Why This Fix Works
This is a standard Java idiom to avoid NullPointerException - by putting the constant string first ("Project".equalsIgnoreCase(oblLevel)), if oblLevel is null, it simply returns false instead of throwing an NPE.
Testing
Fixes #3706