Use random int as registration ID#866
Open
LukasWoodtli wants to merge 1 commit intoeclipse-wakaama:mainfrom
Open
Use random int as registration ID#866LukasWoodtli wants to merge 1 commit intoeclipse-wakaama:mainfrom
LukasWoodtli wants to merge 1 commit intoeclipse-wakaama:mainfrom
Conversation
LukasWoodtli
force-pushed
the
gardena/lw/reg-id-upstream
branch
2 times, most recently
from
89d779e to
5a47861
Compare
LukasWoodtli
force-pushed
the
gardena/lw/reg-id-upstream
branch
3 times, most recently
from
b964a73 to
519389f
Compare
Previously the internal client ID was used as the registration ID. As that ID is recycled it can cause problems due to collisions. Moreover exposing the internal ID does make it public and therefore not internal anymore.
LukasWoodtli
force-pushed
the
gardena/lw/reg-id-upstream
branch
from
519389f to
c6cabe0
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the internal client ID was used as the registration ID. As that ID is recycled it can cause problems due to collisions. Moreover exposing the internal ID does make it public and therefore not internal anymore.