Switch css/less/scss to tm4e grammar/language config#1552
Merged
akurtakov merged 3 commits intoeclipse-wildwebdeveloper:masterfrom May 9, 2024
akurtakov:master
Merged
Switch css/less/scss to tm4e grammar/language config#1552akurtakov merged 3 commits intoeclipse-wildwebdeveloper:masterfrom akurtakov:master
akurtakov merged 3 commits intoeclipse-wildwebdeveloper:masterfrom
akurtakov:master
Conversation
Simplifies wildwebdeveloper development as the project will get the updates from tm4e without the need for CQs and etc.
Contributor
Author
|
@mickaelistria @vrubezhny I would appreciate your review if you have time. |
Contributor
Author
|
Added the xsl switch as second commit as without it tests fail. There is some incompatibility which is visible even with master before this PR if one tries to run org.eclipse.wildwebdeveloper.tests.TestXML.testXSLFile with TM4e language pack installed the test fails with: just like on jenkins (https://ci.eclipse.org/wildwebdeveloper/job/Wildwebdeveloper/job/PR-1552/1/testReport/junit/org.eclipse.wildwebdeveloper.tests/TestXML/testXSLFile/) after the language pack makes it in the dependencies via the first commit of this PR. |
vrubezhny
approved these changes
May 9, 2024
Contributor
vrubezhny
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies wildwebdeveloper development as the project will get the updates from tm4e without the need for CQs and etc.