feat: #COCO-5031, mobile phone checks#937
Merged
pb-jo merged 2 commits intodevelop-b2schoolfrom Dec 19, 2025
Merged
Conversation
pb-jo
force-pushed
the
develop-b2school
branch
from
b4aadd7 to
8ad352f
Compare
pb-jo
force-pushed
the
feat-COCO-5031-mobile-phone-checks
branch
from
0828fde to
62ef364
Compare
vbillard91
requested changes
Dec 15, 2025
common/src/main/java/org/entcore/common/datavalidation/MobileValidation.java
Outdated
Show resolved
Hide resolved
jcbe-ode
reviewed
Dec 15, 2025
Contributor
jcbe-ode
left a comment
jcbe-ode
left a comment
There was a problem hiding this comment.
Pas de remarque particulière, ajouter des TUs me semble important aussi.
|
vbillard91
approved these changes
Dec 19, 2025
jenkinsEdificePublic
pushed a commit
that referenced
this pull request
Dec 22, 2025
* feat: #COCO-5031, mobile phone checks * Feedbacks
jenkinsEdificePublic
pushed a commit
that referenced
this pull request
Jan 6, 2026
* feat: #COCO-5031, mobile phone checks * Feedbacks
pb-jo
added a commit
that referenced
this pull request
Jan 8, 2026
* feat: #COCO-5031, mobile phone checks * Feedbacks
jenkinsEdificePublic
pushed a commit
that referenced
this pull request
Jan 12, 2026
* feat: #COCO-5031, mobile phone checks * Feedbacks
jenkinsEdificePublic
pushed a commit
that referenced
this pull request
Feb 3, 2026
* feat: #COCO-5031, mobile phone checks * Feedbacks
vbillard91
pushed a commit
that referenced
this pull request
Feb 6, 2026
* feat: #COCO-5031, mobile phone checks * Feedbacks
jenkinsEdificePublic
pushed a commit
that referenced
this pull request
Feb 6, 2026
* feat: #COCO-5031, mobile phone checks * Feedbacks
jcbe-ode
pushed a commit
that referenced
this pull request
Feb 10, 2026
* feat: #COCO-5031, mobile phone checks * Feedbacks
damienromito
pushed a commit
that referenced
this pull request
Feb 16, 2026
* feat: #COCO-5031, mobile phone checks * Feedbacks
jenkinsEdificePublic
pushed a commit
that referenced
this pull request
Feb 16, 2026
* feat: #COCO-5031, mobile phone checks * Feedbacks
jenkinsEdificePublic
pushed a commit
that referenced
this pull request
Feb 17, 2026
* feat: #COCO-5031, mobile phone checks * Feedbacks
benjaminperez
pushed a commit
that referenced
this pull request
Feb 19, 2026
* feat: #COCO-5031, mobile phone checks * Feedbacks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Utilisation de la lib libphonenumber de Google pour vérifier que le numéro de mobile saisi par l'utilisateur soit bien un numéro de mobile (certains pays ont besoin de FIXED_LINE_OR_MOBILE) et également que ce ne soit pas un numéro surtaxé.
Pas pu tester à 100% en local, car l'envoi de SMS n'est pas paramétrable (whitelist IP chez Sinch ?).
Fixes
#COCO-5031
Type of change
Please check options that are relevant.
Which packages changed?
Please check the name of the package you changed
Tests
Reminder
Security flaws
Performance impacts (think bulk !)
Unit tests were replayed
Unit tests were added and/or changed
I have updated the reminder for the version including my modifications
All done ! 😃