feat: #RBACK-104 add communcation rules tests for migration#982
Open
vbillard91 wants to merge 8 commits intodevelop-b2schoolfrom
Open
feat: #RBACK-104 add communcation rules tests for migration#982vbillard91 wants to merge 8 commits intodevelop-b2schoolfrom
vbillard91 wants to merge 8 commits intodevelop-b2schoolfrom
Conversation
mariusode
reviewed
Mar 27, 2026
|
|
||
| if(StringUtils.isEmpty(startUser) || StringUtils.isEmpty(endUser) || StringUtils.isEmpty(direction)) { | ||
| renderError(request); | ||
| return; |
Member
There was a problem hiding this comment.
le return; est nécessaire ici ?
Contributor
Author
There was a problem hiding this comment.
oui pour eviter d'executer la suite
jenkinsEdificePublic
force-pushed
the
develop-b2school
branch
from
e9e093d to
92a1896
Compare
Romu-C
force-pushed
the
develop-b2school
branch
from
92a1896 to
7e213f8
Compare
jenkinsEdificePublic
force-pushed
the
develop-b2school
branch
from
7e213f8 to
5b6753f
Compare
jcbe-ode
force-pushed
the
develop-b2school
branch
2 times, most recently
from
823ca0c to
b752688
Compare
jenkinsEdificePublic
force-pushed
the
develop-b2school
branch
from
ee366e9 to
24668ed
Compare
juniorode
approved these changes
Apr 7, 2026
# Conflicts: # admin/src/main/ts/package.json # conversation/frontend/package.json.template # package.json # pom.xml
* feat: add boilerplate for new homepage * chore : replace docker-compose deprecated command * chore: fix build.sh for homepage * chore: rename index.html to homepage.html * feedback from copilot --------- Co-authored-by: jcbe-ode <jean-christophe.benoit@opendigitaleducation.com> # Conflicts: # .husky/pre-commit # build.sh # timeline/frontend/homepage.html # timeline/frontend/package.json # timeline/frontend/src/routes/index.tsx # timeline/frontend/src/routes/redirections/index.tsx # timeline/frontend/src/routes/root/index.tsx # timeline/frontend/vite.config.ts
…imeline2 (#987) * feat(timeline): #COCO-5568, add switch buttons for homepage and timeline2 * add angularJS implementation * feedback from copilot * remove dead code
vbillard91
force-pushed
the
feat-RBACK-104-add-integration-test-for-communication
branch
from
810cb7c to
ce858be
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To validate the migration from neo4j to postgresql for communication rules, add integration test on the various communication.
Fixes
https://edifice-community.atlassian.net/browse/RBACK-104
Type of change
Please check options that are relevant.
Which packages changed?
Please check the name of the package you changed
Tests
Reminder
Security flaws
Performance impacts (think bulk !)
Unit tests were replayed
Unit tests were added and/or changed
I have updated the reminder for the version including my modifications
All done ! 😃