TASK-2026-00448,TASK-2026-00449,TASK-2026-00450:Room Management, Communication Log, and Meeting Room Booking Implementation.#3
Open
ZakkiyathLulu wants to merge 1 commit intodevelopfrom
Open
Conversation
MhmdSinanKT
requested changes
Apr 8, 2026
| if getdate(self.booking_date) < getdate(nowdate()): | ||
| frappe.throw("Booking Date cannot be in the past") | ||
|
|
||
| def validate_room_availability(self): |
Collaborator
There was a problem hiding this comment.
need to validate that there are no other bookings for the same room in the given timeframe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature description
This PR introduces three new DocTypes to support resource management, communication tracking, and meeting room booking functionality.
##Solution Description
Developed a booking system with:
Room selection (filtered to Active rooms)
Booking date and time slots
Purpose and booking status
Added Child Table (Attendees) to include multiple employees.
Validations Implemented:
Prevent booking in the past (booking_date >= today)
Ensure valid time range (to_time > from_time)
Maintain data integrity and avoid incorrect entries
Automation:
Auto-set booked_by from session user
Default booking status set to Pending
Output screenshots (optional)
Areas affected and ensured
Meeting Room
Communication Log
Is there any existing behavior change of other features due to this code change?
No
Was this feature tested on the browsers?