Bug when using --insert without --no-backup#108
Merged
ekalinin merged 1 commit intoekalinin:masterfrom Feb 1, 2021
Merged
Conversation
de1ba8b to
6feec24
Compare
--insert **without** --no-backup
--insert **without** --no-backup--insert without --no-backup
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the
--insertoption to write the TOC back to the analyzed file without using the--no-backupoption, there is a bug because theno_backupvariable is not set in the environment.Example:
As you can see above, there is an error message about a unary operator expected on line line 180. This is because the variable is not secured with quotes for the comparison and leads to an error if not set.
This PR fixes this issue (plus secures an other line to prevent further equivalent bugs).