Merged
Conversation
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #77
The bug was introduced in #104
You will find a test file here: https://github.com/zeitounator/random-files/blob/main/gh-markdown-toc-%23109-test-file.md#do-you-like-c
Important note: the bug was only present when generating the toc from a local file so you will have to save the raw content to a local
.mdfile prior to testing. Here is the raw content from the url for reference. I kept the url to make sure there are no drawbacks when calling it directly.From what I can see:
+when present as fixed in Fix for issue#100 ("+"s in titles) #104Generating from file before the fix:
Generating from file after the fix. Generating from url unaffected (same toc before and after):