Skip to content

Fixed an issue in which the file path containing spaces could not be grepped #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ekalinin merged 9 commits into from
Dec 25, 2022
Merged

Fixed an issue in which the file path containing spaces could not be grepped #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3df975c
Fixed an issue in which the file path containing spaces could not be …
ZeroOnePro Jun 11, 2022
a672102
fix remove backup file path
ZeroOnePro Jun 11, 2022
af97723
Delete configurationCache.log
ZeroOnePro Jun 11, 2022
ff8946e
Delete dryrun.log
ZeroOnePro Jun 11, 2022
72e99ea
Delete settings.json
ZeroOnePro Jun 11, 2022
c679772
Delete targets.log
ZeroOnePro Jun 11, 2022
e261a18
Merge branch 'ekalinin:master' into master
ZeroOnePro Jul 17, 2022
79e8624
add test case for file path with space
ZeroOnePro Jul 17, 2022
7cb9658
modify test script - add --insert flag
ZeroOnePro Jul 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions gh-md-toc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ gh_toc_md2html() {

local gh_tmp_file_md=$gh_file_md
if [ "$skip_header" = "yes" ]; then
if grep -Fxq "<!--te-->" $gh_src; then
if grep -Fxq "<!--te-->" "$gh_src"; then
# cut everything before the toc
gh_tmp_file_md=$gh_file_md~~
sed '1,/<!--te-->/d' $gh_file_md > $gh_tmp_file_md
Expand Down Expand Up @@ -168,7 +168,7 @@ gh_toc(){
local toc=`echo "$rawhtml" | gh_toc_grab "$gh_src_copy" "$indent"`
echo "$toc"
if [ "$need_replace" = "yes" ]; then
if grep -Fxq "<!--ts-->" $gh_src && grep -Fxq "<!--te-->" $gh_src; then
if grep -Fxq "<!--ts-->" "$gh_src" && grep -Fxq "<!--te-->" "$gh_src"; then
echo "Found markers"
else
echo "You don't have <!--ts--> or <!--te--> in your file...exiting"
Expand Down Expand Up @@ -198,7 +198,7 @@ gh_toc(){
fi
echo
if [ "${no_backup}" = "yes" ]; then
rm ${toc_path} ${gh_src}${ext}
rm "$toc_path" "$gh_src$ext"
fi
echo "!! TOC was added into: '$gh_src'"
if [ -z "${no_backup}" ]; then
Expand Down
17 changes: 17 additions & 0 deletions tests/test directory/test_filepathwithspace.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# Title

<!--ts-->

- [Title](#title)
- [This is test for file path with space](#this-is-test-for-file-path-with-space)

<!-- Created by https://github.com/ekalinin/github-markdown-toc -->
<!-- Added by: sungminyou, at: 2022년 7월 17일 일요일 16시 48분 18초 KST -->

<!--te-->

Blabla...

## This is test for file path with space

Blabla...
8 changes: 8 additions & 0 deletions tests/tests.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,3 +201,11 @@ test_help() {

assert_equal "${lines[2]}" "* [C vs C++](#c-vs-c)"
}

@test "Toc for file path with space, #136" {
run $BATS_TEST_DIRNAME/../gh-md-toc --insert tests/test\ directory/test_filepathwithspace.md
assert_success

assert_equal "${lines[2]}" "* [Title](#title)"
assert_equal "${lines[3]}" " * [This is test for file path with space](#this-is-test-for-file-path-with-space)"
}