Added Create TOC without backup option --ins-nb#70
Conversation
|
It looks like you inadvertantly broke some of the test... You might want to look into that. |
|
So it looks like this wasn't my mistake? But rather the Docker section wasn't added properly. I've addressed this as a new commit on my forked branch. Don't know how long it takes to show up here. |
jordantrizz
force-pushed
the
nobackup
branch
from
0bbb67f to
25a094c
Compare
jordantrizz
changed the title
jordantrizz
changed the title
|
Pushed new code that passes tests. |
|
Running the test locally doesn't fail, I don't know why this is failing on travis? @Potherca |
|
Looks like a glitch. I've got the test passing locally too. I've triggered a separate Travis build on my own fork for the changes in this PR and that passes: https://travis-ci.org/potherca-contrib/github-markdown-toc/builds/617162196
I don't have access rights but maybe @ekalinin can manually trigger the build again? |
Thanks! |
|
Thanks for your contribution! |
jordantrizz
force-pushed
the
nobackup
branch
5 times, most recently
from
c653c35 to
e203ebc
Compare
|
I've made the changes you requested, hopefully, they're correct. I'm sorry the last request was so sloppy, I apologize! I wasn't certain how you wanted the usage to be printed out, right now it's kinda ugly due to --no-backup being longer than --insert. Also, I wasn't certain if you wanted --no-backup to require --insert as an argument as well. Which I'm thinking you did. Let me know and I'll fix it so that --insert is required when using --no-backup. |
|
Are you still planning to merge this? |
|
Sorry for delay. Please, check my last comment. |
jordantrizz
force-pushed
the
nobackup
branch
2 times, most recently
from
4985dea to
38e062a
Compare
|
This was my fault, I missed some things. I think I've gotten everything this time @ekalinin |
|
Missed some the tests! Changed them as well. |
|
Thank you both! |
jordantrizz
force-pushed
the
nobackup
branch
2 times, most recently
from
18850a0 to
c9960fe
Compare
|
Alright, little learning lesson here on how to amend pull requests. Sorry about that @ekalinin I think I've made the changes you wanted, can you confirm? |
|
@jordantrizz we're almost done :) |
|
Removed the debug line! |
|
Cool! Thanks! |
|
Thanks to you both! |
4 participants
First time doing this, hopefully, you consider it for merging.
I tried to do a sed append, however, OSX sed requires a new line. It got really tricky and I abandoned it in favor of just generating the TOC files and deleting them. Dirty but works and keeps your repository clean of backup files.