Skip to content

docs: remove reference to Node 10 incompatibility #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
watson merged 3 commits into from
Jul 18, 2018
Merged

docs: remove reference to Node 10 incompatibility #449

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea657c8
docs: remove reference to Node 10 incompatibility
watson Jul 17, 2018
fc6b445
test: re-add Node 10 bail to hapi tests
watson Jul 17, 2018
8afe3d3
test: re-add the old hapi test exceptions
watson Jul 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/compatibility.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ image::https://raw.githubusercontent.com/nodejs/Release/master/schedule.png[]
Some versions of Node.js contain bugs or issues that limit our ability to instrument them correctly.
The following versions of Node.js are known to not be fully instrumented:

- v10.x - Async/Await in Node.js 10 is currently buggy and can therefore not be supported (https://github.com/nodejs/node/issues/20516:[nodejs/node#20516])
- v8.1.x - Recommended solution: Upgrade to v8.2.0 or higher to get full support
- v8.0.x - Recommended solution: Upgrade to v8.2.0 or higher to get full support

Expand Down
4 changes: 2 additions & 2 deletions test/instrumentation/modules/hapi.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ var semver = require('semver')
// hapi 17+ requires Node.js 8.9.0 or higher
if (semver.lt(process.version, '8.9.0') && semver.gte(pkg.version, '17.0.0')) process.exit()

// hapi does not work on Node.js 10 because of https://github.com/nodejs/node/issues/20516
if (semver.gte(process.version, '10.0.0-rc')) process.exit()
Copy link
Copy Markdown
Contributor

@Qard Qard Jul 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than fully removing this, can we change it to a range to indicate that certain early versions of 10.x are broken?

Copy link
Copy Markdown
Contributor Author

@watson watson Jul 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Fixed

// hapi does not work on early versions of Node.js 10 because of https://github.com/nodejs/node/issues/20516
if (semver.satisfies(process.version, '>=10.0.0-rc <10.4.0')) process.exit()

var http = require('http')

Expand Down