[New connector] Onelake connector#3057
Conversation
…onelake connector)
|
💚 CLA has been signed |
|
|
||
| for path in doc_paths: | ||
| file_name = path.name.split("/")[-1] | ||
| field_client = await self._get_file_client(file_name) |
There was a problem hiding this comment.
Looking at the code, for each file multiple clients are created. Is there a way to reuse the clients between calls? I can see how this can become a problem with RAM
There was a problem hiding this comment.
Hello Artem, thank you so much for your feedback.
Regarding this comment: each file client represents a specific file and is initialized with the file name, so it’s not possible to reuse the client. I believe the garbage collector should remove unused clients, but that’s just an assumption.
connectors/sources/onelake.py
Outdated
| def _get_account_url(self): | ||
| """Get the account URL for OneLake | ||
|
|
||
| Returns: | ||
| str: Account URL | ||
| """ | ||
|
|
||
| return f"https://{self.configuration['account_name']}.dfs.fabric.microsoft.com" |
There was a problem hiding this comment.
This can just become an field of the class that's set during init
There was a problem hiding this comment.
I moved it to the constructor method:
…ker-compose and connector.json
|
Hello! I made changes regarding the asynchrony. I converted the synchronous methods to asynchronous using asyncio, based on the implementation of the Google Drive connector. |
2 participants
TITLE: [New connector] Onelake connector
Closes #3051
Added Onelake connector files, the connector’s code, test, requirements and the reference to the connector in the sources list (connectors/config.py)
Checklists
Pre-Review Checklist
config.yml.example)v7.13.2,v7.14.0,v8.0.0)