log4net layout: log latest scope value#367
Merged
Mpdreamz merged 4 commits intoelastic:mainfrom Apr 4, 2024
andreycha:feat/log4net-log-latest-scope-value
Merged
log4net layout: log latest scope value#367Mpdreamz merged 4 commits intoelastic:mainfrom andreycha:feat/log4net-log-latest-scope-value
Mpdreamz merged 4 commits intoelastic:mainfrom
andreycha:feat/log4net-log-latest-scope-value
Conversation
Member
|
run docs-build |
Member
|
Thank you for another excellent PR, @andreycha! |
Contributor
Author
|
@Mpdreamz thanks for checking it quickly! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
If a property is added to the log scope multiple times, currently all its values are logged in metadata/labels. This is how log4net also behaves but in most of the cases it is undesired behavior. Only latest property value should be included (e.g., Serilog behaves the same way).
Example:
Breaking change: yes (comparing to how log4net behaves by default)
Changes
Peek()method