Move exception stack trace to ECS-compliant field for StructlogFormatter#97
Merged
basepi merged 4 commits intoJul 25, 2023
Conversation
|
💚 CLA has been signed |
basepi
approved these changes
Jul 24, 2023
basepi
left a comment
basepi
left a comment
Contributor
There was a problem hiding this comment.
This looks great! I made a small fix to use pytest fixtures in your test.
Contributor
Author
|
Thanks for the quick review! Is there an ETA for the release? |
Contributor
|
Well, if I can ever get the docs build to actually go, I can probably release it in the next week or two. 😅 |
Contributor
|
@elasticmachine, run elasticsearch-ci/docs |
Contributor
|
@elasticmachine, run elasticsearch-ci/docs |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the StructlogFormatter, logs with exceptions (e.g. produced by using
logger.exception(...)) currently result in aexceptionkey at the root of the log, which is not a valid ECS field. It should be in theerror.stack_tracefield instead.This PR addresses a small part of the disparity between the StructlogFormatter and the StdlibFormatter . Until that is addressed in it's entirety, this patch will help users of this package (like myself) to output logs that comply with the ECS specification.