Use Count instead of Count()#8604
Merged
Merged
Conversation
Member
|
Hi @gpetrou , thanks for the PR. I'm usually running a "report everything & treat warnings as errors" |
Contributor
Author
|
@flobernd do I need to do any changes or could we merge this one? |
Member
|
Hi @gpetrou , I merged it right now. Thanks again! FYI: I'm on leave until August; there won't be a lot of movement here in the meantime. |
github-actions Bot
pushed a commit
that referenced
this pull request
Jul 2, 2025
(cherry picked from commit 1f98816)
github-actions Bot
pushed a commit
that referenced
this pull request
Jul 2, 2025
(cherry picked from commit 1f98816)
Contributor
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
github-actions Bot
pushed a commit
that referenced
this pull request
Aug 4, 2025
(cherry picked from commit 1f98816)
Contributor
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
flobernd
pushed a commit
that referenced
this pull request
Aug 4, 2025
flobernd
pushed a commit
that referenced
this pull request
Aug 4, 2025
flobernd
pushed a commit
that referenced
this pull request
Aug 4, 2025
This was referenced Aug 5, 2025
Closed
Closed
This was referenced Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be nice to enable NetAnalyzers to flag such cases.
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1826
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1829