[SecuritySolution][Endpoint] Relax API schema for scripts library item updates

x-pack/solutions/security/plugins/security_solution/common/api/endpoint/scripts_library/common.ts

@@ -36,8 +36,10 @@ export const ScriptPathToExecutableSchema = schema.string({
   validate: validateNonEmptyString,
 });
 
-export const ScriptTagsSchema = schema.arrayOf(
-  // @ts-expect-error TS2769: No overload matches this call. (due to now `oneOf()` type is defined)
-  schema.oneOf(Object.keys(SCRIPT_TAGS).map((osType) => schema.literal(osType))),
-  { minSize: 1, maxSize: Object.keys(SCRIPT_TAGS).length, validate: validateNoDuplicateValues }
-);
+export const getScriptsTagSchema = (type: 'patch' | 'post') =>
+  // @ts-expect-error TS2769: No overload matches this call. (due to how `oneOf()` type is defined)
+  schema.arrayOf(schema.oneOf(Object.keys(SCRIPT_TAGS).map((osType) => schema.literal(osType))), {
+    minSize: type === 'patch' ? 0 : 1,
+    maxSize: Object.keys(SCRIPT_TAGS).length,
+    validate: validateNoDuplicateValues,
+  });

x-pack/solutions/security/plugins/security_solution/common/api/endpoint/scripts_library/create_script.ts

@@ -16,7 +16,7 @@ import {
   ScriptPathToExecutableSchema,
   ScriptPlatformSchema,
   ScriptRequiresInputSchema,
-  ScriptTagsSchema,
+  getScriptsTagSchema,
 } from './common';
 
 export const CreateScriptRequestSchema = {
@@ -29,7 +29,7 @@ export const CreateScriptRequestSchema = {
     instructions: schema.maybe(ScriptInstructionsSchema),
     example: schema.maybe(ScriptExampleSchema),
     pathToExecutable: schema.maybe(ScriptPathToExecutableSchema),
-    tags: schema.maybe(ScriptTagsSchema),
+    tags: schema.maybe(getScriptsTagSchema('post')),
   }),
 };
 

x-pack/solutions/security/plugins/security_solution/common/api/endpoint/scripts_library/update_script.ts

@@ -7,15 +7,11 @@
 
 import { schema, type TypeOf } from '@kbn/config-schema';
 import {
-  ScriptDescriptionSchema,
-  ScriptExampleSchema,
   ScriptFileSchema,
-  ScriptInstructionsSchema,
   ScriptNameSchema,
-  ScriptPathToExecutableSchema,
   ScriptPlatformSchema,
   ScriptRequiresInputSchema,
-  ScriptTagsSchema,
+  getScriptsTagSchema,
 } from './common';
 import type { DeepMutable } from '../../../endpoint/types';
 import { validateNonEmptyString } from '../schema_utils';
@@ -27,11 +23,11 @@ export const PatchUpdateScriptRequestSchema = {
       platform: schema.maybe(ScriptPlatformSchema),
       file: schema.maybe(ScriptFileSchema),
       requiresInput: schema.maybe(ScriptRequiresInputSchema),
-      description: schema.maybe(ScriptDescriptionSchema),
-      instructions: schema.maybe(ScriptInstructionsSchema),
-      example: schema.maybe(ScriptExampleSchema),
-      pathToExecutable: schema.maybe(ScriptPathToExecutableSchema),
-      tags: schema.maybe(ScriptTagsSchema),
+      description: schema.maybe(schema.string()),
+      instructions: schema.maybe(schema.string()),
+      example: schema.maybe(schema.string()),
+      pathToExecutable: schema.maybe(schema.string()),
+      tags: schema.maybe(getScriptsTagSchema('patch')),
       version: schema.maybe(schema.string({ minLength: 1, validate: validateNonEmptyString })),
     },
     {

x-pack/solutions/security/plugins/security_solution/common/endpoint/schema/scripts_library.test.ts

@@ -305,6 +305,20 @@ describe('Scripts library schemas', () => {
       ).toBeTruthy();
     });
 
+    it.each([
+      { field: 'description', value: '' },
+      { field: 'instructions', value: '' },
+      { field: 'example', value: '' },
+      { field: 'pathToExecutable', value: '' },
+      { field: 'tags', value: [] },
+    ])('should accept `$field` field with `$value` value', ({ field, value }) => {
+      expect(
+        PatchUpdateScriptRequestSchema.body.validate({
+          [field]: value,
+        })
+      ).toBeTruthy();
+    });
+
     it.each`
       title                 | bodyPayload
       ----------             -------------