You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
One commit was added on top of a8d0a9a6: 467a6c03, the merge of the updated parent feat/protected-content-custody (checkpoint 4 tip, CI-green — strict statement-signature verification and the checkpoint 3 fixes below it). No fixes were needed on this checkpoint itself.
Review notes: the bridge from VerifiedKeyReleaseRequestV1 to AuthenticatedRuntimeReleaseOperationV1 preserves the reconstruction check order exactly (envelope identity → recipient → exact threshold → per-node verify/dedupe → terminal receipt → Released outcome → open → combine → constant-time commitment), the old request-based entry correctly drops to #[cfg(test)], and the 12 new tests mirror the prior edge cases through the new path.
Two observations carried from the checkpoint 4 review that become slightly more relevant here (no code changed): (a) verify_node_contribution/verify_terminal_receipt re-verify the operation statement but not the operation's own issued/expires window — safe via the current sole caller, but the new public reconstruction entry now leans on that invariant; (b) expected_terminal_issuer stays caller-supplied, and the new happy-path test passes the receipt's own issuer (circular for that test; wrong-issuer negatives from checkpoint 4 still cover it).
Verified locally at the tip: all source gates incl. the provisional-retirement guard, cargo fmt --check, cargo clippy --workspace --all-targets -- -D warnings, cargo test --workspace — 2090 passed (only the known macOS mDNS-environment room::direct pair plus one under-load-only wallet-timeout flake, all green on this CI run).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This is part of a stacked PR chain — review only the commits of this checkpoint; earlier work is in the PRs below it in the stack.
Stack (top → bottom)
feat/protected-content-runtime-lifecyclefeat/protected-content-rightsfeat/protected-content-runtimefeat/protected-content-wallet-rightsfeat/protected-content-custody-providerfeat/protected-content-key-reconstruction(this PR)feat/protected-content-custodyfeat/protected-content-contractsreview/collaboration-product-integrationreview/collaboration-foundationmainBase:
feat/protected-content-custody← Head:feat/protected-content-key-reconstruction(checkpoint 5 of 10)Commits