Skip to content

feat(protected-content): bridge authenticated release reconstruction - #31

Closed
irzhywau wants to merge 2 commits into
feat/protected-content-custodyfrom
feat/protected-content-key-reconstruction
Closed

irzhywau wants to merge 2 commits into
feat/protected-content-custodyfrom
feat/protected-content-key-reconstruction

Conversation

@irzhywau

@irzhywau irzhywau commented Aug 26, 2026 •

Copy link
Copy Markdown
Collaborator

Note

This is part of a stacked PR chain — review only the commits of this checkpoint; earlier work is in the PRs below it in the stack.

Stack (top → bottom)

Base: feat/protected-content-custody ← Head: feat/protected-content-key-reconstruction (checkpoint 5 of 10)

Commits

  • a8d0a9a feat(protected-content): bridge authenticated release reconstruction

@irzhywau

Copy link
Copy Markdown
Collaborator Author

One commit was added on top of a8d0a9a6: 467a6c03, the merge of the updated parent feat/protected-content-custody (checkpoint 4 tip, CI-green — strict statement-signature verification and the checkpoint 3 fixes below it). No fixes were needed on this checkpoint itself.

Review notes: the bridge from VerifiedKeyReleaseRequestV1 to AuthenticatedRuntimeReleaseOperationV1 preserves the reconstruction check order exactly (envelope identity → recipient → exact threshold → per-node verify/dedupe → terminal receipt → Released outcome → open → combine → constant-time commitment), the old request-based entry correctly drops to #[cfg(test)], and the 12 new tests mirror the prior edge cases through the new path.

Two observations carried from the checkpoint 4 review that become slightly more relevant here (no code changed): (a) verify_node_contribution/verify_terminal_receipt re-verify the operation statement but not the operation's own issued/expires window — safe via the current sole caller, but the new public reconstruction entry now leans on that invariant; (b) expected_terminal_issuer stays caller-supplied, and the new happy-path test passes the receipt's own issuer (circular for that test; wrong-issuer negatives from checkpoint 4 still cover it).

Verified locally at the tip: all source gates incl. the provisional-retirement guard, cargo fmt --check, cargo clippy --workspace --all-targets -- -D warnings, cargo test --workspace — 2090 passed (only the known macOS mDNS-environment room::direct pair plus one under-load-only wallet-timeout flake, all green on this CI run).

@irzhywau irzhywau added this to the 0.7.x milestone Aug 28, 2026
@irzhywau irzhywau closed this Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants