Skip to content

test(people): the first-run layout smoke waits for the rendered Profile text - #422

Draft
SashaMIT wants to merge 1 commit into
developfrom
fix/people-first-run-smoke-wait
Draft

SashaMIT wants to merge 1 commit into
developfrom
fix/people-first-run-smoke-wait

Conversation

@SashaMIT

Copy link
Copy Markdown
Contributor

What this changes

scripts/people-product-layout-smoke.mjs assertFirstRunScenario used to wait for the title "Create your Profile". The static capsules/people/browser/index.html:45 already shows that title before people.js runs. Now the smoke waits for the description that only people.js:296 writes: "Confirm the name people will see in People and Chat…". After that wait, the existing asserts read the rendered first-run state. Only test code changes.

Why

CI job 117377843374 (run 39022786845, test-capsules, step just product-ui-browser, PR #67) failed with:

Error: first run explanation is wrong
{ "count": "0 contacts", "title": "Create your Profile",
  "description": "Your Profile is your signed identity for People and Chat.",
  "value": "", "placeholder": "Your name", "submit": "Create Profile" }

Every field holds its static HTML value (index.html:45,46,50,51,56). This means the asserts ran before people.js rendered. #67 does not touch capsules/people. I ran the smoke on develop 9be009b1 and on develop merged with #67, three times each. The first-run scenario passed every time on both.

Proof

On this branch, three runs: the first-run scenario passes. Each run then stops at the same later step, visible discovery did not open Inbox through the Home target bridge, which also fails here on unmodified develop. This machine's local Chromium setup causes that step to fail; this change does not touch it. CI is the full check for that step. node --check and git diff --check are clean.

Gap: the race depends on timing. The fix removes the wait condition that the static HTML already satisfied. Local passes alone do not prove the race is gone.

Merged into

#67, as commit 0f9bfd4. That PR's CI failed on this race.


Generated by Claude Code

…le text

assertFirstRunScenario waited for the title "Create your Profile", which the
static index.html already shows before people.js runs. On a slow runner the
checks then read the page before render. CI job 117377843374 (run
39022786845) failed "first run explanation is wrong" with every field at its
static HTML value: "0 contacts", the HTML description, an empty name and
"Create Profile". The wait now uses the description that only people.js
writes. Test code only.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01W6Qn9RX7LDqrwiAfNC2F2K
@SashaMIT

Copy link
Copy Markdown
Contributor Author

Review: A. The smoke passes locally and the wait matches the failure in run 39022786845. Ready for Anders once CI is green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants