Repository navigation
Conversation
…le text assertFirstRunScenario waited for the title "Create your Profile", which the static index.html already shows before people.js runs. On a slow runner the checks then read the page before render. CI job 117377843374 (run 39022786845) failed "first run explanation is wrong" with every field at its static HTML value: "0 contacts", the HTML description, an empty name and "Create Profile". The wait now uses the description that only people.js writes. Test code only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W6Qn9RX7LDqrwiAfNC2F2K
Contributor
Author
|
Review: A. The smoke passes locally and the wait matches the failure in run 39022786845. Ready for Anders once CI is green. |
This was referenced Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
scripts/people-product-layout-smoke.mjsassertFirstRunScenarioused to wait for the title "Create your Profile". The staticcapsules/people/browser/index.html:45already shows that title beforepeople.jsruns. Now the smoke waits for the description that onlypeople.js:296writes: "Confirm the name people will see in People and Chat…". After that wait, the existing asserts read the rendered first-run state. Only test code changes.Why
CI job 117377843374 (run 39022786845,
test-capsules, stepjust product-ui-browser, PR #67) failed with:Every field holds its static HTML value (
index.html:45,46,50,51,56). This means the asserts ran beforepeople.jsrendered. #67 does not touchcapsules/people. I ran the smoke on develop9be009b1and on develop merged with #67, three times each. The first-run scenario passed every time on both.Proof
On this branch, three runs: the first-run scenario passes. Each run then stops at the same later step,
visible discovery did not open Inbox through the Home target bridge, which also fails here on unmodified develop. This machine's local Chromium setup causes that step to fail; this change does not touch it. CI is the full check for that step.node --checkandgit diff --checkare clean.Gap: the race depends on timing. The fix removes the wait condition that the static HTML already satisfied. Local passes alone do not prove the race is gone.
Merged into
#67, as commit 0f9bfd4. That PR's CI failed on this race.
Generated by Claude Code