Fixes #7758: Fixed JWT token for Jitsi openidtoken-jwt authentication#8341
Merged
Conversation
…entication Signed-off-by: Alexey Nechaev <seysane@yahoo.com>
6b9d453 to
28da02c
Compare
langleyd
approved these changes
Aug 28, 2023
Member
langleyd
left a comment
There was a problem hiding this comment.
I've looked over these changes and have tested them on an environment where I could reproduce the issue. Thanks for fix!
Member
|
Thanks @langleyd . I do not see how to trigger the CI again, but I think this is fine to merge the PR. I can handle issue if it breaks something. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Used the hard-coded key from the module
prosody-mod-auth-matrix-user-verificationto sign the JWT for Jitsiopenidtoken-jwtauthentication to pass token validation at Prosody side.Motivation and context
#7758
Screenshots / GIFs
Tests
Tested devices
Checklist