Skip to content

Fixes #7758: Fixed JWT token for Jitsi openidtoken-jwt authentication#8341

Merged
bmarty merged 1 commit into
element-hq:developfrom
tomtit:bugfix/issue-7758
Aug 28, 2023
Merged

Fixes #7758: Fixed JWT token for Jitsi openidtoken-jwt authentication#8341
bmarty merged 1 commit into
element-hq:developfrom
tomtit:bugfix/issue-7758

Conversation

@tomtit
Copy link
Copy Markdown
Contributor

@tomtit tomtit commented Apr 18, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Used the hard-coded key from the module prosody-mod-auth-matrix-user-verification to sign the JWT for Jitsi openidtoken-jwt authentication to pass token validation at Prosody side.

Motivation and context

#7758

Screenshots / GIFs

Tests

  • start a group video call
  • get into the video call

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 6.0, Android 10.0

Checklist

…entication

Signed-off-by: Alexey Nechaev <seysane@yahoo.com>
@tomtit tomtit force-pushed the bugfix/issue-7758 branch from 6b9d453 to 28da02c Compare April 22, 2023 16:32
@bmarty bmarty requested a review from BillCarsonFr April 24, 2023 09:17
@bmarty bmarty added the Z-Community-PR Issue is solved by a community member's PR label May 11, 2023
@langleyd langleyd self-requested a review August 28, 2023 11:11
Copy link
Copy Markdown
Member

@langleyd langleyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've looked over these changes and have tested them on an environment where I could reproduce the issue. Thanks for fix!

@bmarty
Copy link
Copy Markdown
Member

bmarty commented Aug 28, 2023

Thanks @langleyd . I do not see how to trigger the CI again, but I think this is fine to merge the PR. I can handle issue if it breaks something.

@bmarty bmarty merged commit a3be028 into element-hq:develop Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Z-Community-PR Issue is solved by a community member's PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants