Skip to content

Allow stateloss on verification dialogfragment#8439

Merged
bmarty merged 2 commits into
developfrom
yostyle/fix_crash_on_start_verification
May 25, 2023
Merged

Allow stateloss on verification dialogfragment#8439
bmarty merged 2 commits into
developfrom
yostyle/fix_crash_on_start_verification

Conversation

@yostyle
Copy link
Copy Markdown
Contributor

@yostyle yostyle commented May 17, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

The app crashes sometimes when self verification dialog tries to show.

Motivation and context

Exception java.lang.IllegalStateException: Can not perform this action after onSaveInstanceState
  at androidx.fragment.app.FragmentManager.checkStateLoss (FragmentManager.java:1610)
  at androidx.fragment.app.FragmentManager.enqueueAction (FragmentManager.java:1650)
  at androidx.fragment.app.BackStackRecord.commitInternal (BackStackRecord.java:341)
  at androidx.fragment.app.BackStackRecord.commit (BackStackRecord.java:306)
  at androidx.fragment.app.DialogFragment.show (DialogFragment.java:262)
  at im.vector.app.features.navigation.DefaultNavigator.requestSelfSessionVerification (DefaultNavigator.kt:273)
  at im.vector.app.features.home.HomeActivity$onCreate$3.invoke (HomeActivity.kt:275)
  at im.vector.app.features.home.HomeActivity$onCreate$3.invoke (HomeActivity.kt:266)

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@yostyle yostyle requested review from a team, giomfo and jonnyandrew and removed request for a team May 17, 2023 09:14
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@bmarty bmarty merged commit cff9fbd into develop May 25, 2023
@bmarty bmarty deleted the yostyle/fix_crash_on_start_verification branch May 25, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants