fix always returning live devices for current user#8457
Merged
Conversation
BillCarsonFr
added
X-Release-Blocker
Z-NextRelease
bmarty
approved these changes
May 22, 2023
Member
bmarty
left a comment
bmarty
left a comment
There was a problem hiding this comment.
LGTM. Maybe worth adding a quick changelog file, since the fix will be in the next release 1.6.1.
| return olmMachine.getLiveDevices(listOf(myUserId)).map { | ||
| it.filter { it.userId == myUserId } | ||
| } | ||
| return olmMachine.getLiveDevices(userIds) |
Member
There was a problem hiding this comment.
Good catch. The mapping to filter with myUserId was also quite useless, no? Anyway it's gone now :)
BillCarsonFr
force-pushed
the
feature/bca/fix_bad_device_list
branch
from
c61501f to
19dc812
Compare
bmarty
approved these changes
May 23, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Corrective bug fix on beta candidate.
The liveCryptoDevice() call was always returning the current user device list instead of the targeted member device list
Motivation and context
Screenshots / GIFs
Tests
Tested devices
Checklist