Implement Mobile Device Manager feature with 3 keys.#8698
Conversation
ganfra
left a comment
There was a problem hiding this comment.
One change on the DI otherwise LGTM
| return Matrix(context, configuration) | ||
| } | ||
|
|
||
| @Provides |
There was a problem hiding this comment.
You should use @Singleton otherwise listeners won't be kept.
Also use @Binds instead of @Provides
There was a problem hiding this comment.
Done in 6452b5c, hence I think it was fine since the listener was added and removed by the same entity (the Activity).
OK for you?
|
SonarCloud Quality Gate failed.
|












Type of change
Content
Add support for MDM with the following keys:
im.vector.app.serverConfigDefaultHomeserverUrlStringim.vector.app.serverConfigSygnalAPIUrlStringim.vector.app.clientPermalinkBaseUrliOS PR: element-hq/element-ios#7667
Motivation and context
Support MDM.
Internal issue: https://github.com/vector-im/element-internal/issues/527
Screenshots / GIFs
Tests
Cannot test using a real MDM configuration, but can be tested by hacking the method getData to return a custom string.
I have tested by returning a value for
MdmData.DefaultHomeserverUrldifferent frommatrix.organd the application was correctly defaulting to the provided homeserver.Also currently when the MDM configuration change, this is a no-op on the application. We may consider logging out the user.
Tested devices
Checklist