Try fixing exodus CI job#8721
Merged
Merged
Conversation
jmartinesp
force-pushed
the
test/jme/exodus
branch
6 times, most recently
from
ad6fa3e to
f9f26fb
Compare
jmartinesp
force-pushed
the
test/jme/exodus
branch
from
f9f26fb to
a0518c7
Compare
bmarty
approved these changes
Dec 29, 2023
Member
bmarty
left a comment
bmarty
left a comment
There was a problem hiding this comment.
LGTM, hence I did not spend time to test the changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Make Exodus ignore Sentry, as it's a known an opt-in tracker.
Motivation and context
Exodus now detects Sentry and was failing because of this. The new code should ensure it's the only detected tracker and make the check pass.